🌱 Remove klog from tests #2072
Merged
🌱 Remove klog from tests #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
nrb
force-pushed
the
tests-klog-to-t
branch
from
445e320 to
b3e2d90
Compare
ncdc
reviewed
Sep 26, 2022
nrb
force-pushed
the
tests-klog-to-t
branch
from
b3e2d90 to
4e66fe0
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Memory limit issue, @stevekuznetsov is bumping that up. /retest |
nrb
force-pushed
the
tests-klog-to-t
branch
from
4e66fe0 to
0e5e765
Compare
ncdc
suggested changes
Sep 29, 2022
test/e2e/customresourcedefinition/customresourcedefinition_test.go
Outdated
Show resolved
Hide resolved
test/e2e/customresourcedefinition/customresourcedefinition_test.go
Outdated
Show resolved
Hide resolved
nrb
force-pushed
the
tests-klog-to-t
branch
3 times, most recently
from
c9f8751 to
f8629d5
Compare
Signed-off-by: Nolan Brubaker <[email protected]>
nrb
force-pushed
the
tests-klog-to-t
branch
from
f8629d5 to
1942ffa
Compare
ncdc
approved these changes
Sep 29, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests should utilize
testing.T's methods for output, rather than klog.Related issue(s)
Part of #1694