-
Notifications
You must be signed in to change notification settings - Fork 406
✨ relax workspace object name validation #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ relax workspace object name validation #2341
Conversation
Hi @mjudeikis. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
d7dac9c
to
65993b3
Compare
ping @ncdc |
pkg/server/filters/filters.go
Outdated
// reClusterName is a regular expression for cluster names. It is based on | ||
// modified RFC 1123. It allows for 63 characters for single name and includes | ||
// KCP specific ':' separator for workspace nesting. We are not re-using k8s | ||
// validation regex because it purpose is for single name validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// validation regex because it purpose is for single name validation | |
// validation regex because its purpose is for single name validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 ⌨️ 💣
Just 1 typo in a comment |
65993b3
to
a09c38d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-sharded |
bye bye:
|
Summary
Relaxes workspce object name validation accross the board to be able to start with digit. This allows use of GUID libaries to generate names. In addition this brings us closer to k8s upstream and RFC 1123. But now (not until workspaces are flatened) we are not abel fully re-use k8s validation
Related issue(s)
Fixes #