Skip to content

📖 Attempt to update doc on workspaces #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

MikeSpreitzer
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer commented Dec 15, 2022

.. but I do not understand the Workspace/ClusterWorkspace duality, so that part is still not clear.

Summary

This PR attempts to update the doc on workspaces.
Note: I do not understand the Workspace/ClusterWorkspace duality, so this doc may need more work in that regard.

Related issue(s)

Fixes #623

.. but I do not understand the Workspace/ClusterWorkspace duality,
so that part is still not clear.
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@ncdc
Copy link
Member

ncdc commented Dec 15, 2022

This looks great, thanks @MikeSpreitzer!

@openshift-merge-robot openshift-merge-robot merged commit 747c8bc into kcp-dev:main Dec 15, 2022
@MikeSpreitzer MikeSpreitzer deleted the wsdoc-to-v10 branch December 16, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminology inconsistency in doc on workspaces
3 participants