✨ Add wget to final image

[mjudeikis]

Summary

When running kcp in docker and want to add simple heathchecks, this gets tricky. See the issue below. Dont want to add curl as its way too big, but wget should do just fine to achieve:

HEALTHCHECK --interval=30s \
            --timeout=5s \
            CMD ["/usr/bin/wget", "--no-verbose", "--tries=1", "--spider", "https://localhost:6443/health"]

GoogleContainerTools/distroless#183

Related issue(s)

Fixes #

Release Notes

add wget to final image

[embik]

Have you tested this? Since the builder stage is docker.io/golang (which is based on Debian), I don't think the wget binary is statically linked, so it would miss dependencies when trying to run it in distroless.

[mjudeikis]

I ran docker build locally and it worked. Did something changed recently? Gonna try again tomorrow

[embik]

I ran docker build locally and it worked. Did something changed recently? Gonna try again tomorrow

docker build would work, but have you tested if the wget command in the resulting image is functional? 🤔

[mjudeikis]

I ran docker build locally and it worked. Did something changed recently? Gonna try again tomorrow

docker build would work, but have you tested if the wget command in the resulting image is functional? 🤔

 => => naming to docker.io/library/test                                                                                       0.0s
~/go/src/github.com/kcp-dev/kcp mjudeikis/agg.wget 1m 8s ❯ docker run --entrypoint sh -it test                            15:57:23
/data $ wget google.com
Connecting to google.com (216.58.207.206:80)
Connecting to www.google.com (142.250.74.164:80)
saving to 'index.html'
index.html           100% |***********************************************************************************| 19284  0:00:00 ETA
'index.html' saved
/data $ 

🤷

[embik]

/approve

Okay, then let's go! 🚀

[kcp-ci-bot]

LGTM label has been added.

Git tree hash: 35d27b4e13715a04cec3ad6105b0543647c3f9b6

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [embik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[embik]

/kind chore

[kcp-ci-bot]

@embik: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

/kind chore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[embik]

/kind cleanup