Skip to content

🌱 Add kube feature gate for global service account #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

🌱 Add kube feature gate for global service account #3328

merged 3 commits into from
Mar 17, 2025

Conversation

cnvergence
Copy link
Member

@cnvergence cnvergence commented Mar 12, 2025 •
edited by embik
Loading

Summary

Hiding the ability to use a global ServiceAccount behind a feature flag until it will become ready with #3274.
This PR aims to unblock the release, bumping k8s fork with kcp-dev/kubernetes#165.

Related issue(s)

Part of #3289 and #3274

Release Notes

Provide a feature gate `GlobalServiceAccount` that enables cross-workspace `ServiceAccount` authorization (requires `--service-account-lookup=false` in sharded environments).

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2025
@kcp-ci-bot
Copy link
Contributor

Hi @cnvergence. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cnvergence cnvergence changed the title WIP: add kube feature gate from k8s fork 🌱 WIP: add kube feature gate from k8s fork Mar 12, 2025
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2025
@cnvergence cnvergence changed the title 🌱 WIP: add kube feature gate from k8s fork Add kube feature gate for global service account Mar 13, 2025
@cnvergence cnvergence changed the title Add kube feature gate for global service account 🌱 Add kube feature gate for global service account Mar 13, 2025
@cnvergence cnvergence marked this pull request as ready for review March 13, 2025 10:24
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2025
@sttts
Copy link
Member

sttts commented Mar 13, 2025

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2025
@embik embik added this to the v0.27.0 milestone Mar 14, 2025
@cnvergence
Copy link
Member Author

/retest

@embik
Copy link
Member

embik commented Mar 14, 2025

@cnvergence Can we please add a release note naming the feature gate and what it does, so we have this on the release notes?

@embik embik requested review from sttts and mjudeikis March 14, 2025 10:38
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 14, 2025
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
@cnvergence cnvergence requested a review from sttts March 17, 2025 12:13
embik
embik approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7179af1c2090d199e6b0c5a3ebc3ad4c374b1043

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
@embik
Copy link
Member

embik commented Mar 17, 2025

/retest

?

@kcp-ci-bot kcp-ci-bot merged commit e52a887 into kcp-dev:main Mar 17, 2025
16 checks passed
@cnvergence cnvergence deleted the test-feature-gate branch March 17, 2025 14:01
@embik
Copy link
Member

embik commented Mar 18, 2025

/kind feature

@kcp-ci-bot kcp-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@mjudeikis mjudeikis Awaiting requested review from mjudeikis

@sttts sttts Awaiting requested review from sttts

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cnvergence @kcp-ci-bot @sttts @embik