Refactor namespace scheduler queueing behavior for testability #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
add-queueing-test
branch
7 times, most recently
from
b47e01b to
c6d1185
Compare
sttts
reviewed
Mar 1, 2022
sttts
reviewed
Mar 1, 2022
sttts
approved these changes
Mar 1, 2022
ncdc
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor separates the decision of how to respond to a cluster event in the namespace scheduler from how that decision is implemented. This allows for unit testing of the decision-making.
This PR also ensures that when enqueueing scheduled namespaces, only namespaces scheduled to the specific cluster will be enqueued.