e2e: Update cross logical cluster testing to use private fixture #811
Conversation
Also restrict test usage of shared fixture to `Private` and `Shared` to avoid adding new fixture usage without consideration.
marun
force-pushed
the
e2e-fix-cross-cluster
branch
from
6c7e175 to
17c42d5
Compare
These tests operate against global state which precludes successive invocations against shared fixture without error.
marun
force-pushed
the
e2e-fix-cross-cluster
branch
from
17c42d5 to
70910aa
Compare
|
I don't think this is necessary. Just make the global state unique enough to not fall over other parallel tests. |
If you - or whoever wrote this test - want to fix it, by all means. I've already spent considerable effort getting e2e running with shared fixture and at this point my priority is getting the e2e-shared-server job to the point where it can prevent further regression. This PR accomplishes that, and in no way precludes future changes that would re-enable use of shared fixture. FWIW, moving to private fixture also ensures these tests execute in a reasonable amount of time. When running against shared fixture even once, this test takes 45s on my machine. It takes <10s running independently. |
These tests operate against global state which precludes successive
invocations against shared fixture without error.
Fixes #802