Stop apiimporter, syncer, heartbeat from fighting over the Ready condition #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csams
force-pushed
the
fix-ready-slapfight
branch
2 times, most recently
from
6075c80 to
5bda7f7
Compare
csams
force-pushed
the
fix-ready-slapfight
branch
from
5bda7f7 to
243f2b3
Compare
Give each controller its own condition and make them responsible for setting Ready by accounting for all conditions via conditions.SetSummary Signed-off-by: Christopher Sams <[email protected]>
csams
force-pushed
the
fix-ready-slapfight
branch
from
243f2b3 to
9d381ac
Compare
Signed-off-by: Christopher Sams <[email protected]>
ncdc
reviewed
Apr 8, 2022
Signed-off-by: Christopher Sams <[email protected]>
ncdc
approved these changes
Apr 8, 2022
|
@marun @imjasonh how does this look to you? For background/additional context: the conditions library we're using (from Cluster API) went through extensive R&D, settling on the use of SetSummary to summarize a resource's Ready condition. It's a good practice to follow, and even if we only currently have a single condition that represents Ready, for future-proofing, we should choose a unique name for that condition, and have it flow into Ready via SetSummary. |
imjasonh
approved these changes
Apr 8, 2022
kylape
pushed a commit
to kylape/kcp
that referenced
this pull request
Apr 14, 2022
Stop apiimporter, syncer, heartbeat from fighting over the Ready condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give each controller its own condition and make heartbeat manager responsible for setting
Readyby accounting for all conditions viaconditions.SetSummaryUpdate the namespace scheduler to depend on total readiness.
Fixes #865