Skip to content

cmd/kcp: add --feature-gates flag #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2022
Merged

cmd/kcp: add --feature-gates flag #930

merged 2 commits into from
Apr 26, 2022

Conversation

sttts
Copy link
Member

@sttts sttts commented Apr 25, 2022 •
edited
Loading

Used as in kube:

  • on the command line: --feature-gates=Foo=true
  • in code: if utilfeature.DefaultFeatureGate.Enabled(kcpfeatures.Foo).
  • In kcp start options: Bildschirmfoto 2022-04-25 um 14 07 13

davidfestal
davidfestal approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@sttts sttts merged commit 17aa360 into kcp-dev:main Apr 26, 2022
@ncdc ncdc mentioned this pull request Apr 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfestal davidfestal davidfestal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sttts @davidfestal