Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout parameter for HTTP client in Azure Log Analytics and Prometheus scalers #1548

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zroubalik
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates kedacore/keda#6607

@zroubalik zroubalik requested a review from a team as a code owner March 6, 2025 14:10
Copy link

github-actions bot commented Mar 6, 2025

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for keda ready!

Name Link
🔨 Latest commit a9f65f2
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/67c9f9313888860008acae73
😎 Deploy Preview https://deploy-preview-1548--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rickbrouwer
Copy link
Contributor

Is it maybe a good idea to adjust the warning message here (https://keda.sh/docs/2.16/operate/cluster/#http-timeouts) to clarify that it is possible to override it for some scalers

@zroubalik
Copy link
Member Author

Is it maybe a good idea to adjust the warning message here (https://keda.sh/docs/2.16/operate/cluster/#http-timeouts) to clarify that it is possible to override it for some scalers

you are right! I wanted to do that and forgot about that.

@rickbrouwer
Copy link
Contributor

A small nit. It is milliseconds instead of miliseconds.

@zroubalik
Copy link
Member Author

A small nit. It is milliseconds instead of miliseconds.

lol, thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants