Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks to serialization. #20751

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

hertschuh
Copy link
Collaborator

No description provided.

In particular for functional models.
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (3d20616) to head (d664807).
Report is 117 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/saving/serialization_lib.py 50.00% 2 Missing and 2 partials ⚠️
keras/src/models/functional.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20751      +/-   ##
==========================================
- Coverage   81.95%   81.95%   -0.01%     
==========================================
  Files         553      553              
  Lines       51458    51460       +2     
  Branches     7961     7962       +1     
==========================================
+ Hits        42174    42175       +1     
  Misses       7346     7346              
- Partials     1938     1939       +1     
Flag Coverage Δ
keras 81.78% <45.45%> (-0.01%) ⬇️
keras-jax 64.04% <45.45%> (-0.01%) ⬇️
keras-numpy 58.90% <45.45%> (-0.01%) ⬇️
keras-openvino 29.84% <9.09%> (+<0.01%) ⬆️
keras-tensorflow 64.70% <45.45%> (-0.01%) ⬇️
keras-torch 64.08% <45.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 12, 2025
@fchollet fchollet merged commit e67ac8f into keras-team:master Jan 12, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 12, 2025
@hertschuh hertschuh deleted the functional_serial branch January 13, 2025 02:54
@hertschuh
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants