Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVino BackEnd]support np.count_nonzero for ov BackEnd #20945

Merged

Conversation

Mohamed-Ashraf273
Copy link
Contributor

Added support np.count_nonzero for ov backend, related to #29114.
@rkazants
could you please review?

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (da10cf3) to head (bd6dcc7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20945   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         561      561           
  Lines       53226    53241   +15     
  Branches     8244     8247    +3     
=======================================
+ Hits        43871    43886   +15     
  Misses       7338     7338           
  Partials     2017     2017           
Flag Coverage Δ
keras 82.24% <100.00%> (+<0.01%) ⬆️
keras-jax 63.97% <0.00%> (-0.02%) ⬇️
keras-numpy 58.79% <0.00%> (-0.02%) ⬇️
keras-openvino 32.63% <100.00%> (+0.02%) ⬆️
keras-tensorflow 64.45% <0.00%> (-0.02%) ⬇️
keras-torch 64.03% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mohamed-Ashraf273
Copy link
Contributor Author

hi @rkazants
I resolved the problem, could you please review it?

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

@Mohamed-Ashraf273 Mohamed-Ashraf273 force-pushed the support_np.count_nonzeros_ov_be branch 2 times, most recently from 7507dff to 6f0800a Compare February 25, 2025 15:23
@Mohamed-Ashraf273
Copy link
Contributor Author

@rkazants , @fchollet
The issue has been resolved. Everything is working now.

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, recommend to merge. Thanks in advance!

@fchollet fchollet merged commit 0902ff4 into keras-team:master Feb 28, 2025
7 checks passed
11happy pushed a commit to 11happy/keras that referenced this pull request Mar 9, 2025
…#20945)

* suppoer np.count_nonzero for ov BackEnd

* modifing function vars to lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants