Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log-viewer- improvements #1061

Merged
merged 2 commits into from
Mar 21, 2025
Merged

feat: log-viewer- improvements #1061

merged 2 commits into from
Mar 21, 2025

Conversation

WilsonNet
Copy link
Collaborator

@WilsonNet WilsonNet commented Mar 11, 2025

Closes #996

@WilsonNet WilsonNet changed the title wip feat: log-viewer- improvements Mar 11, 2025
@murilx murilx force-pushed the feat/log-viewer-improvements branch 5 times, most recently from 52c9353 to 577754d Compare March 19, 2025 17:23
@murilx murilx marked this pull request as ready for review March 19, 2025 17:27
@murilx murilx self-assigned this Mar 19, 2025
@murilx murilx force-pushed the feat/log-viewer-improvements branch 2 times, most recently from 055a247 to fdd85fc Compare March 19, 2025 19:32
Copy link
Collaborator

@Francisco2002 Francisco2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murilx murilx force-pushed the feat/log-viewer-improvements branch from fdd85fc to 21d5b1b Compare March 20, 2025 19:31
@murilx murilx force-pushed the feat/log-viewer-improvements branch from 21d5b1b to 3ca152f Compare March 21, 2025 13:04
WilsonNet and others added 2 commits March 21, 2025 11:50
Added a new hook that get all the extra data needed to add to the log
viewer. Also adds the search params needed for the full log viewer page
and adds any necessary field in the build details/test details backend
endpoints
- Adds the new info to the log viewer modal and page
- Updates the application to use the new hook and pass the correct data

Closes #996
@murilx murilx force-pushed the feat/log-viewer-improvements branch from 3ca152f to b9adb67 Compare March 21, 2025 14:51
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@murilx murilx merged commit 06c8911 into main Mar 21, 2025
5 checks passed
@murilx murilx deleted the feat/log-viewer-improvements branch April 3, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve log exerpt viewer
4 participants