Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: drop origin from issue listing #1105

Merged
merged 6 commits into from
Mar 21, 2025

Conversation

Francisco2002
Copy link
Collaborator

Close #1075

How to test

  • Navigate to issue listing page and see that origin select isn't in the header
  • Navigate through the other pages to see that origin select isn't hidden in that
  • Run tests

@Francisco2002 Francisco2002 self-assigned this Mar 20, 2025
@Francisco2002 Francisco2002 force-pushed the feat/drop-origin-from-issue-listing branch from 1b7a38c to de22fd1 Compare March 20, 2025 17:10
Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much slower but worked well on my tests

Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that @murilx added the culprit_code filter in the frontend, but I believe that with the query being as slow as it got now, it might be better to move that filter to the backend query, because with your current change the backend is trying to get the first_seen value for 297 issues but it will only show the 172 issues with culprit_code == true in the frontend. Filtering in the backend via an optional query parameter and defaulting it to culprit_code in the frontend would lower the request time while keeping the option to get all culprits via the api if needed.

@Francisco2002 Francisco2002 force-pushed the feat/drop-origin-from-issue-listing branch from de22fd1 to c3708c7 Compare March 21, 2025 14:51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add tests for the new query parameters

@Francisco2002 Francisco2002 force-pushed the feat/drop-origin-from-issue-listing branch 2 times, most recently from 1238d90 to 6fdfbf9 Compare March 21, 2025 18:23
Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working well, but you should update the requests file related to this change. I believe it's issue-listing-get.sh

Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well on my tests, I also think the request file should be updated, but I'll approve already

@Francisco2002 Francisco2002 force-pushed the feat/drop-origin-from-issue-listing branch from 6fdfbf9 to 9b5f921 Compare March 21, 2025 19:10
@Francisco2002 Francisco2002 force-pushed the feat/drop-origin-from-issue-listing branch from 9b5f921 to d2665b2 Compare March 21, 2025 19:12
Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well on my tests

@@ -1,4 +1,4 @@
http 'localhost:8000/api/issue/?origin=maestro&intervalInDays=1'
http 'localhost:8000/api/issue/?&intervalInDays=1&culpritCode=true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not necessarily need to come with culpritCode but I like the addition

@Francisco2002 Francisco2002 merged commit acfc41f into main Mar 21, 2025
5 checks passed
@Francisco2002 Francisco2002 deleted the feat/drop-origin-from-issue-listing branch March 21, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop origin selector from Issues
3 participants