apply plugin network filters to TCP filter chains #10822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lgadban
reviewed
Mar 13, 2025
| reporter, | ||
| ) | ||
|
|
||
| if len(envoyListener.FilterChains) == 0 { |
There was a problem hiding this comment.
can we also assert the expected length of the FilterChains?
that would have helped me parsing this test (and the desired behavior of the fc.go changes) and seems like a good assertion in general
Signed-off-by: Steven Landow <[email protected]>
lgadban
approved these changes
Mar 13, 2025
lol |
Signed-off-by: Steven Landow <[email protected]>
|
lol that's what I get for using the web editor; fixed
|
lgadban
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split out from #10783
share code for applying custom fitler chain field and from plugins for both HTTP and TCP chains
Context
Needed for waypoints, which add NetworkFilter globally to every chain on sandwiched proxies.
Testing steps
Added a unit test