Skip to content

Fixes issue #356 : Keychain with protocolType and accessGroup #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fixes issue #356 : Keychain with protocolType and accessGroup #363

wants to merge 3 commits into from

Conversation

yangyubo
Copy link
Contributor

Refer issue #356 for detailed discussion.

@kishikawakatsumi kishikawakatsumi self-requested a review December 16, 2017 14:27
@codecov
Copy link

codecov bot commented Dec 16, 2017 •
edited
Loading

Codecov Report

Merging #363 into master will decrease coverage by 44.14%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #363       +/-   ##
===========================================
- Coverage   90.76%   46.62%   -44.15%     
===========================================
  Files           1        1               
  Lines        1755     1750        -5     
===========================================
- Hits         1593      816      -777     
- Misses        162      934      +772
Impacted Files Coverage Δ
Lib/KeychainAccess/Keychain.swift 46.62% <100%> (-44.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b0025...b312bfc. Read the comment docs.

@kishikawakatsumi
Copy link
Owner

@yangyubo Thanks! Somehow I overlooked existing behaviour. It looks good to me. I will merge soon after I test compatibility.

@yangyubo
Copy link
Contributor Author

yangyubo commented Jan 8, 2018

@kishikawakatsumi Any progress? Is there any other things I can do for this PR?

@jeff-h
Copy link

jeff-h commented May 9, 2018

@kishikawakatsumi it would be great to get this rolled in if you're happy with it 👍

jeff-h added a commit to jeff-h/sharedKeychainAccessDemo that referenced this pull request Oct 5, 2019
@jeff-h
Test PR kishikawakatsumi/KeychainAccess#363
df49b7a
@jeff-h
Copy link

jeff-h commented Oct 5, 2019

I've tested this now in my sample app (https://github.com/jeff-h/sharedKeychainAccessDemo) and it works great there. Would be great to see this PR rolled in.

@kishikawakatsumi
Copy link
Owner

Superseded #450

kishikawakatsumi
kishikawakatsumi approved these changes Oct 26, 2019
View reviewed changes
Copy link
Owner

@kishikawakatsumi kishikawakatsumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kishikawakatsumi
Copy link
Owner

Superseded #450

@kishikawakatsumi
Copy link
Owner

Fixed by #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishikawakatsumi kishikawakatsumi kishikawakatsumi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangyubo @kishikawakatsumi @jeff-h