-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify why PytorchModel and CnnResampleLoss subclasses exist #443
Labels
docs
Related to documentation or tutorials but not src code
Comments
@louisfh there is one difference between
On second thought, Since the Resnet18Binary and Resnet18Multiclass models now only appear in tutorials during "Advanced CNN training" specifically for the feature they are meant for, I think we can probably leave them without deprecating/removing. Avg user will never know they exist. |
sammlapp
added a commit
that referenced
this issue
Mar 21, 2022
clarifies differences between Resnet18Multiclass/Resnet18Binary and pytorchmodel in the class docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think we should clarify why the subclasses of PytorchModel and CnnResampleLoss (e.g. Resnet18Multiclass, InceptionV3 class) exist. As I understand this is for backwards compatibility? We could explain why these model classes are implemented in the docstrings/or somewhere else in the docs, and mention that
Resnet18Multiclass(classes)
is equivalent tocnn.PytorchModel('resnet18',classes)...
The text was updated successfully, but these errors were encountered: