Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove species_table.py module #396

Merged
merged 4 commits into from
Nov 21, 2021

Conversation

louisfh
Copy link
Member

@louisfh louisfh commented Nov 14, 2021

Closes #292 by using importlib.resources to import species_table.csv, instead of having the species_table.py python module. This requires the resources folder to be
a sub-package.

@louisfh louisfh closed this Nov 14, 2021
@louisfh louisfh reopened this Nov 14, 2021
@sammlapp
Copy link
Collaborator

Noting that importlib.resources will require Python >=3.7

@sammlapp sammlapp self-requested a review November 16, 2021 15:41
@sammlapp
Copy link
Collaborator

Nice, seems to be a very simple change. I'm a bit wary of the path structure being system/os/package setup dependent. Could you test that it works properly in these scenarios?

  • poetry install
  • pip install local package path, ie pip install ~/my_opso/opensoundscape

Can probably just run pytest after installing to check if working

@louisfh
Copy link
Member Author

louisfh commented Nov 19, 2021

This works on a fresh environment on Ubuntu 20.04.

I couldn't get this branch, develop or master to build and correctly run pytest using poetry installor pip install path on a Windows 10 machine.
EDIT: Oops - not surprising. I realize OpSo does not support Windows, except in using WSL.

@sammlapp sammlapp merged commit d7f13a4 into kitzeslab:develop Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants