Feat 569 audio #622
Merged
Feat 569 audio #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods of Audio (duration, and newly added rms and dBFS) and Spectrogram (duration, window_length, window_step, window_start_times) should be _properties_ (calculated values that are accessed like an attribute) rather than methods. I've updated this code, which makes breaking changes - code calling, for instance, Audio.duration() will throw an error.
concatenate Audio objects end-to-end from a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #569 by adding Audio.normalize. Also adds Audio.rms and Audio.dBFS.
Breaking changes!
Changes several Audio and Spectrogram methods to properties, which is a breaking change. For instance, now
Audio.durationis correct andAudio.duration()will throw an error.