add gcc (generalized cross correlation) function and tests #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammlapp
reviewed
Apr 14, 2023
outputs need to be swapped around, and trimmed to remove padded regions. This results in equivalent outputs to scipy.signal.correlate and np.correlate. Because of this, we can use scipy.signal.correlation_lags rather than implementing a different version.
we just use 'n' to "pad" the rfft for "full" mode, then trim the results afterwards
adds function to estimate time difference of arrival (tdoa) of two discrete-time signals.
numpy -> torch use optimal length fft added arg for `radius` but haven't implemented (raises NotImplementedError if not None)
still needs tests - and might not be necessary/useful.
updates variable names in signal_processing.tdoa and audio.estimate_delay to be more intuitive: signal, reference. (If first arrives earlier, delay is negative; if second arrives earlier, delay is positive).
also adds a test for this functionality
HT filter had two mistakes - gamma denominator had Gxx*Gxy instead of Gxx*Gyy - phi denominator had coherence instead of (1-coherence) where coherence is |gamma| ^2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of generalized cross correlation. There are some things that should be changed - either before in PR or in a later release.