Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Scaffold to avoid Subcompose & fix insets consumption #534

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

hrach
Copy link
Contributor

@hrach hrach commented Sep 19, 2023

closes #500
closes #376

@hrach hrach added bug Something isn't working feature New feature or request labels Sep 19, 2023
@hrach hrach requested a review from a team as a code owner September 19, 2023 15:29
@hrach hrach changed the title Rework Scaffold to avoid Subscompose & fix insets consumption Rework Scaffold to avoid Subscompose & fix insets consumption Sep 19, 2023
@hrach hrach added this to the Q3/2023 milestone Sep 19, 2023
@hrach hrach force-pushed the scaffold-refactoring branch from 645d2b3 to 30338dc Compare September 19, 2023 15:32
@hrach hrach mentioned this pull request Sep 19, 2023
8 tasks
@hrach hrach self-assigned this Sep 19, 2023
@Drekorian Drekorian changed the title Rework Scaffold to avoid Subscompose & fix insets consumption Rework Scaffold to avoid Subcompose & fix insets consumption Sep 19, 2023
@hrach hrach merged commit 940b6a9 into main Sep 20, 2023
@hrach hrach deleted the scaffold-refactoring branch September 20, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving Scaffold from using subcompose layout Properly support nested Scaffolds/insets
2 participants