Add IconName and IllustrationName enums
#580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerak-cz
commented
Nov 15, 2023
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.graphics.painter.Painter | ||
|
|
||
| public enum class IllustrationNames { |
There was a problem hiding this comment.
@hrach Please check if the Suppress("unused") is needed here or on the painter().
I see no unused warnings in my IDE.
hrach
reviewed
Nov 15, 2023
catalog/src/main/java/kiwi/orbit/compose/catalog/screens/IconsScreen.kt
Outdated
Show resolved
Hide resolved
illustrations/src/androidMain/res/drawable-hdpi/il_orbit_ambulance.png
Outdated
Show resolved
Hide resolved
generator/src/main/java/kiwi/orbit/compose/generator/icons/IconsGenerator.kt
Outdated
Show resolved
Hide resolved
Drekorian
approved these changes
Nov 15, 2023
gerak-cz
force-pushed
the
icon-illustration-enum
branch
from
d44a2ab to
32ba22d
Compare
added 5 commits
November 15, 2023 13:22
…ension to separate file.
…nter extension to separate file.
gerak-cz
force-pushed
the
icon-illustration-enum
branch
from
32ba22d to
926e445
Compare
hrach
approved these changes
Nov 15, 2023
hrach
changed the title
IconName and IllustrationName enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.