Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is broken on empty tab page #499

Open
xvitaly opened this issue Jul 24, 2020 · 10 comments
Open

Search is broken on empty tab page #499

xvitaly opened this issue Jul 24, 2020 · 10 comments

Comments

@xvitaly
Copy link
Contributor

xvitaly commented Jul 24, 2020

Steps to reproduce:

  1. Load Wikipedia ZIM file.
  2. Press the New tab button.
  3. Try to search anything. No search suggestions will be shown.

System configuration:

  • Kiwix version: 2.0.4.
  • OS: Fedora 32.
@jatinverma12
Copy link

I want to work on this issue. May I?

@kelson42
Copy link
Collaborator

@jatinverma12 You are welcome. Please describe here first how your solution would look like.

@jatinverma12
Copy link

I am new to this repo. Interested to contribute so I was searching for good first issue and came across this. I will try to look into the code and try to fix it.

@stale
Copy link

stale bot commented Dec 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Dec 12, 2020
@ploum
Copy link

ploum commented Jan 10, 2021

On Ubuntu, search looks completely broken. It worked once, now it doesn’t without chnaging anything. No suggestion, no results.

@stale stale bot removed the stale label Jan 10, 2021
@kelson42
Copy link
Collaborator

@ploum Sounds to be a different problem. I believe this zim file is quite old and we might have a problem of compatibility problem with these older files. Would you be able please to open an other ticket please?

@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@ynikitenko
Copy link

ynikitenko commented Apr 6, 2023

I have a similar problem with an existing (single) tab. I can use Ctrl-L (thanks to a previous fix) to position the cursor in the search region, but after I type several words and click on some entries through the shown pages, the search sometimes glitches, and I can't type anything to get a new search.
I have to use Kiwix 0.9, which doesn't have these issues (but it uses an outdated ZIM file).

UPD: I mean, I can type something, but it doesn't open the needed page with Enter or a suggestion.
Also, when I fresh open Kiwix, I can type "how", but there are also variants starting with uppercase, and sometimes I have to choose the variant manually, or the uppercase variant is preferred. Also, I have to select the entry with up-down keys, because typing the word is not enough. It's really distracting to read through many word articles like that (I use it for Wiktionary)!

@ynikitenko
Copy link

Sadly for Kiwix 2.3.1 (on Arch Linux) this problem still persists.

@sgourdas
Copy link
Collaborator

It is not clear to me what is the correct behavior when typing in search, while in an empty tab. In general I feel like the new tab serves no purpose and should be removed, as discussed in a different thread.

Please enlighten me if I have not understood something correctly, but I don't see an issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants