-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REGRESSION] Suggestions are not diacritics insensitive anymore #758
Comments
@DerK777 Thank you for your bug report. In the future, please open one ticket per bug. The part (2) of your bug report is a know bug/limitation, see kiwix/kiwix-desktop#499. |
@DerK777 I confirm your first bug. It seems to be a problem with suggestions an diacritics. Hopefully as soon as we will have moved mwoffliner to the latest libzim7, this bug will simply vanish. See openzim/mwoffliner#1606 |
Thanks, I got the point. I must write "таифун" instead of "тайфун". |
@mgautierfr @veloman-yunkan Suggestions seems not diacritics insensitive anymore indeed. I search for example |
@kelson42 We don't have such a unit-test for suggestions that checks handling of diacritics. Also, while trying to add one (as the first step toward resolving this issue), I ran against the problem that the ZIM files used in our libkiwix unit tests don't have any articles with diacritics in the titles. |
@veloman-yunkan If is it necessary to implement #601 fo get this feature properly tested then we will have to do that in TOP priority IMO. But, at the level of maturity we have now in libkiwix, such a regression is for me a bad surprise. Correlated to #722 and #742, this let me think a strong and quick push in searching features automated testing is necessary. |
The broken feature now has a unit test for the underlying component in libzim, however without proper testing on the libkiwix level we cannot be sure that it works correctly. I believe that #601 is an important task and the sooner we resolve it the better. |
Hello. I Have some problems with kiwix. Software version 2.2.1 Windows Desktop Russian. File Wikipedia russian 04.2022. But all older versions had the same problems. Please help to find a solution.
But it works really good with the word "Ураган" (Hurricane), for example.
It didn't depend on language, it didn't find "Hurricane" too.
The text was updated successfully, but these errors were encountered: