Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix some bugs, and add extra details for seer entries #345

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: fix some bugs, and add extra details for seer entries #345

wants to merge 5 commits into from

Conversation

kemuru
Copy link
Collaborator

@kemuru kemuru commented Mar 11, 2025 •
edited
Loading

image I took the video below before making the change above, where the market image and the market name are displayed in a row instead of being a column (only on desktop), looks better like that
Screen.Recording.2025-03-12.at.03.03.58.mov

@kemuru kemuru requested review from gmkung and clesaege March 11, 2025 15:49
@kemuru kemuru marked this pull request as draft March 11, 2025 16:45
@kemuru kemuru marked this pull request as ready for review March 11, 2025 20:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gmkung
gmkung approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@gmkung gmkung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as discussed with Marino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmkung gmkung gmkung approved these changes

@clesaege clesaege Awaiting requested review from clesaege

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemuru @gmkung