Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim PNK #265

Open
Tracked by #681 ...
jaybuidl opened this issue Sep 5, 2022 · 1 comment · May be fixed by #1331 or #1913
Open
Tracked by #681 ...

Claim PNK #265

jaybuidl opened this issue Sep 5, 2022 · 1 comment · May be fixed by #1331 or #1913

Comments

@jaybuidl
Copy link
Member

jaybuidl commented Sep 5, 2022

image

Scenario 1 - Staking Rewards Program is on-going

Scenario 2 - Staking Rewards Program is halted

  • Do not show "APY: x%"
  • If Unclaimed === 0 then disable the Claim button.
  • Edge case:
    • A user with unclaimed rewards from previous periods should be able to claim, even when the reward program is currently halted.
@jaybuidl jaybuidl mentioned this issue Sep 5, 2022
31 tasks
@jaybuidl jaybuidl changed the title Buy/Claim PNK Claim PNK Sep 7, 2022
This was referenced Apr 10, 2023
@greenlucid
Copy link

greenlucid commented May 10, 2023

I'd patch up the logic to:

Scenario 1 - Staking Rewards Program is on-going

Calculate the APY, claimed and unclaimed amounts

#658

Scenario 2 - Staking Rewards Program is halted

Do not show "APY: x%"

On every case:

If Unclaimed !== 0, show the Claim Button.
If Unclaimed === 0 then:

  • if no active Staking Rewards program, hide the Claim Button.
  • if active Staking Rewards program, show the disabled Claim Button.

Edge case: A user with unclaimed rewards from previous periods should be able to claim...

Omitted since it's part of the logic now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants