Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking Rewards #681

Open
3 tasks
jaybuidl opened this issue Apr 10, 2023 · 1 comment · May be fixed by #1913
Open
3 tasks

Staking Rewards #681

jaybuidl opened this issue Apr 10, 2023 · 1 comment · May be fixed by #1913
Labels
Package: Contracts Court smart contracts Package: Web Court web frontend Type: Feature🗿

Comments

@jaybuidl
Copy link
Member

jaybuidl commented Apr 10, 2023

@jaybuidl jaybuidl added Type: Feature🗿 Type: Epic 🐉 A large user story that can be broken down into a number of smaller stories. Package: Web Court web frontend Package: Contracts Court smart contracts Priority: Low labels Apr 10, 2023
@greenlucid
Copy link

greenlucid commented May 10, 2023

There's a missing activity: pnk-merkle-drop (or rather, the pnk-merkle-drop-v2 we build onto the kleros-v2 monorepo) needs to be made compatible with v2 interface, events, etc. There might even be a decision to make, regarding dispute kits: do we want to only support staking on particular "dispute kits" courts? (I'm not familiar with how this system works yet, just stating that it's not straightforward)

I assume, we would simply target the "vanilla" kleros dispute kit and distribute rewards in there. But, I'm just making sure.

Otherwise, the frontend logic will be similar to v1, and the merkle drop contract should be the exact same, excluding

Maybe, since the frontend does not directly interact with the script that is generating the PNK reward snapshots, writing the scripts to generate the PNK could be done last?

There's an ugliness I would like to address: the way we currently do it at V1, is generate the snapshot, upload to ipfs, send the PNK to the merkle contract, and then manually (with a PR like this) add the ipfs links to the snapshots to a file in the court frontend. Maybe, since we're already rethinking this, we could use a slightly different merkle contract in which we also pass the ipfs link so that's emitted, and then we don't need to pollute the repo with manual monthly additions of snapshots

@jaybuidl jaybuidl mentioned this issue Jun 7, 2023
33 tasks
@jaybuidl jaybuidl removed Priority: Low Type: Epic 🐉 A large user story that can be broken down into a number of smaller stories. labels Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Contracts Court smart contracts Package: Web Court web frontend Type: Feature🗿
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants