Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): crashing appeal tab #1291

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix(web): crashing appeal tab #1291

merged 1 commit into from
Oct 20, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Oct 20, 2023

PR-Codex overview

Detailed summary

  • Refactored the getCurrentLocalRound function in useClassicAppealContext.tsx to handle cases where dispute is undefined.
  • Added a check for dispute being undefined at the beginning of the function and returning undefined in that case.
  • Adjusted the logic for calculating adjustedRoundIndex based on the value of period.
  • Returned the result of getLocalRounds based on the adjusted currentLocalRoundIndex.

Note: There are no notable changes mentioned for getPaidFees function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 0ff85f8
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6532d4ac8541f300084030f7
😎 Deploy Preview https://deploy-preview-1291--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 20, 2023

Code Climate has analyzed commit 0ff85f8 and detected 0 issues on this pull request.

View more on Code Climate.

@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 20, 2023
@kemuru kemuru merged commit 0ff85f8 into dev Oct 20, 2023
@jaybuidl jaybuidl deleted the fix(web)/crashing-appeal-tab branch October 20, 2023 19:35
@jaybuidl jaybuidl linked an issue Oct 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appeal tab - without Payoff Simulator
2 participants