Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add parameters field, improve styling, small mapping adjus… #1472

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Feb 1, 2024

…tments

image image

template used:
{"title":"{{escrowTitle}}","description":"{{deliverableText}}","question":"Which party abided by the terms of the contract?","answers":[{"title":"Refund the Buyer","description":"Select this to return the funds to the Buyer."},{"title":"Pay the Seller","description":"Select this to release the funds to the Seller."}],"policyURI":"ipfs://TODO","attachment":{"label":"Transaction Terms","uri":"{{extraDescriptionUri}}"},"frontendUrl":"https://escrow-v2.kleros.builders/#/myTransactions/{{transactionId}}","arbitrableChainID":"421614","arbitrableAddress":"0x10f7A6f42Af606553883415bc8862643A6e63fdA","arbitratorChainID":"421614","arbitratorAddress":"0xA54e7A16d7460e38a8F324eF46782FB520d58CE8","metadata":{"buyer":"{{address}}","seller":"{{sendingRecipientAddress}}","amount":"{{sendingQuantity}}","asset":"{{asset}}","deadline":"{{deadline}}","transactionUri":"{{transactionUri}}"},"category":"Escrow","specification":"KIPXXX","aliases":{"Buyer":"{{address}}","Seller":"{{sendingRecipientAddress}}"},"version":"1.0"}

data mapping used:
[ { "type": "graphql", "endpoint": "https://api.thegraph.com/subgraphs/name/kemuru/escrow-v2-devnet", "query": "query GetTransaction($transactionId: ID!) { escrow(id: $transactionId) { transactionUri buyer seller amount asset deadline } }", "variables": { "transactionId": "30" }, "seek": ["escrow.transactionUri", "escrow.buyer", "escrow.seller", "escrow.amount", "escrow.asset", "escrow.deadline"], "populate": ["transactionUri", "address", "sendingRecipientAddress", "amount", "asset", "deadline"] }, { "type": "fetch/ipfs/json", "ipfsUri": "context.transactionUri", "seek": ["title", "description", "extraDescriptionUri"], "populate": ["escrowTitle", "deliverableText", "extraDescriptionUri"] } ]


PR-Codex overview

Detailed summary

  • Updated padding in TestnetBanner component
  • Added a new link in the Explore component
  • Updated the validateSubgraphMapping function in actionTypeValidators.ts
  • Added new imports in useContractAddress.tsx
  • Added new code in createResultObject.ts
  • Updated the DisputeMappings.json.mustache file
  • Updated the DisputeTemplate.json.mustache file
  • Updated the DisputeTemplateView component

The following files were skipped due to too many changes: web/src/pages/DisputeTemplateView.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for kleros-v2 failed.

Name Link
🔨 Latest commit f7b6240
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65bc3e43388d7e0008c8bc40

@kemuru kemuru requested review from jaybuidl and alcercu February 1, 2024 10:51
@jaybuidl jaybuidl linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

codeclimate bot commented Feb 2, 2024

Code Climate has analyzed commit b41e91b and detected 13 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 8

Note: there is 1 critical issue.

View more on Code Climate.

@jaybuidl
Copy link
Member

jaybuidl commented Feb 2, 2024

Played around with the styling
image

@jaybuidl jaybuidl merged commit f7b6240 into dev Feb 2, 2024
@jaybuidl jaybuidl deleted the feat(web)/dispute-template-view-improvements branch February 2, 2024 00:59
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispute Preview (dev tool)
2 participants