Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/evidence attachment display #1613

Merged
merged 14 commits into from
Jun 19, 2024
Merged

Conversation

Harman-singh-waraich
Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich commented Jun 11, 2024

PR-Codex overview

This PR introduces new features and improvements related to file viewing and attachment display in the application.

Detailed summary

  • Increased z-index in the Header component
  • Added a hidden class for @cyntler/react-doc-viewer
  • Updated sorting criteria in useEvidences query
  • Added new routes and components for evidence attachment display
  • Styled custom scrollbars
  • Added new SVG icons for new tab and arrow left
  • Implemented Markdown file rendering functionality
  • Created a loader component
  • Styled the header for attachment display
  • Updated EvidenceCard component with new functionalities

The following files were skipped due to too many changes: web/src/components/EvidenceCard.tsx, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 0df6943
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6672b62c22ff6e0008535ccb
😎 Deploy Preview https://deploy-preview-1613--kleros-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for kleros-v2-neo ready!

Name Link
🔨 Latest commit 0df6943
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/6672b62c3b6b4b00085610e3
😎 Deploy Preview https://deploy-preview-1613--kleros-v2-neo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for kleros-v2-university failed. Why did it fail? →

Name Link
🔨 Latest commit 0df6943
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/6672b62cb1a9990008adae4b

Copy link
Contributor

coderabbitai bot commented Jun 11, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • dependencies

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Harman-singh-waraich Harman-singh-waraich marked this pull request as ready for review June 12, 2024 08:22
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I want to be able to open the source file in a new tab (not download it), its more comfortable for me, how would I do that
  2. would it be possible to add a dark mode? maybe inverting colors depending on the {theme} the user is in (light or dark mode)
image

@Harman-singh-waraich
Copy link
Contributor Author

  1. I want to be able to open the source file in a new tab (not download it), its more comfortable for me, how would I do that
  2. would it be possible to add a dark mode? maybe inverting colors depending on the {theme} the user is in (light or dark mode)
  1. We can add a "Open in new tab" link or just the icon .
  2. I have already configured dark theme for the markdown and text. As for Images, i kept the white background so it's easier to see the boundaries. For PDF, we cannot set dark theme

@jaybuidl jaybuidl linked an issue Jun 12, 2024 that may be closed by this pull request
@kemuru kemuru self-requested a review June 12, 2024 16:59
kemuru
kemuru previously approved these changes Jun 12, 2024
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now 🤔 can replicate in escrow-v2 later

@github-actions github-actions bot added the Type: UX User Experience label Jun 19, 2024
Copy link

codeclimate bot commented Jun 19, 2024

Code Climate has analyzed commit 0df6943 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

View more on Code Climate.

Copy link

@jaybuidl jaybuidl merged commit de4c5d6 into dev Jun 19, 2024
16 of 22 checks passed
@jaybuidl jaybuidl deleted the feat/evidence-attachment-display branch October 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evidence: display attachments in a container component
4 participants