feat(web): Evidence: display submission timestamp #1617

ShubhamParkhi · 2024-06-13T18:18:26Z

closes #1590

PR-Codex overview

The focus of this PR is to add a timestamp field to evidence-related components and update the subgraph version.

Detailed summary

Added timestamp field to evidence-related components
Updated subgraph version to 0.5.1
Modified EvidenceCard to display and format timestamps

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

… dev

netlify · 2024-06-13T18:18:29Z

✅ Deploy Preview for kleros-v2 ready!

Name	Link
🔨 Latest commit	`3f2934c`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2/deploys/667012173b94950008cb9121
😎 Deploy Preview	https://deploy-preview-1617--kleros-v2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-06-13T18:18:30Z

‼️ Deploy request for kleros-v2-neo rejected.

Name	Link
🔨 Latest commit	`3f2934c`

netlify · 2024-06-13T18:18:30Z

❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →

Name	Link
🔨 Latest commit	`3f2934c`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/6670121783c4820009c9cc68

coderabbitai · 2024-06-13T18:18:31Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

dependencies

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kemuru · 2024-06-17T09:31:24Z

web/src/components/EvidenceCard.tsx

@@ -96,6 +97,10 @@ const DesktopText = styled.span`
  )}
 `;

+const Timestamp = styled.p`
+  color: #BECCE5;


instead of this:

color: #BECCE5;

do this:

color: ${({ theme }) => theme.secondaryText};

this is because we have all the color scheme centralized for both dark mode and light mode, you can check on the styles/themes.ts folder

kemuru · 2024-06-17T10:00:27Z

web/src/components/EvidenceCard.tsx

@@ -137,6 +143,11 @@ const EvidenceCard: React.FC<IEvidenceCard> = ({ evidence, sender, index }) => {
          <Identicon size="24" string={sender} />
          <p>{shortenAddress(sender)}</p>
        </AccountContainer>
+        <Timestamp>{new Date(parseInt(timestamp) * 1000).toLocaleDateString('en-US', {


instead of the above, do this:

<Timestamp>{formatDate(Number(timestamp))}</Timestamp>

its cleaner since we already have this util function at

import { formatDate } from "utils/date";

kemuru

lgtm, I redeployed the official core devnet subgraphs

kemuru

lgtm

codeclimate · 2024-06-17T10:39:47Z

Code Climate has analyzed commit 3f2934c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.

ShubhamParkhi added 2 commits June 13, 2024 23:43

feat(web): Evidence: display submission timestamp

d31e700

Merge branch 'dev' of https://github.com/ShubhamParkhi/kleros-v2 into…

651dc4d

… dev

kemuru marked this pull request as draft June 14, 2024 09:17

Fix(web): Display of timestamp

75d5019

kemuru self-requested a review June 14, 2024 13:35

ShubhamParkhi added 2 commits June 14, 2024 22:08

Fix(web): Updated styling for timestamp

5229e39

fix(web): Improved code quality and responsive

d35fe08

kemuru reviewed Jun 17, 2024

View reviewed changes

ShubhamParkhi added 2 commits June 17, 2024 15:35

fix(web): Font colour change, used function already defined

e786dda

fix(web): cleaner code

afc8f04

kemuru marked this pull request as ready for review June 17, 2024 10:09

kemuru self-requested a review June 17, 2024 10:09

kemuru previously approved these changes Jun 17, 2024

View reviewed changes

chore: updated package json version for subgraph

3f2934c

kemuru dismissed their stale review via 3f2934c June 17, 2024 10:38

kemuru self-requested a review June 17, 2024 10:39

kemuru approved these changes Jun 17, 2024

View reviewed changes

jaybuidl added this pull request to the merge queue Jun 17, 2024

jaybuidl added Type: Feature🗿 Package: Web Court web frontend labels Jun 17, 2024

Merged via the queue into kleros:dev with commit 3da67bd Jun 17, 2024
9 of 17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(web): Evidence: display submission timestamp #1617

feat(web): Evidence: display submission timestamp #1617

ShubhamParkhi commented Jun 13, 2024 •

edited by pr-codex bot

Loading

netlify bot commented Jun 13, 2024 •

edited

Loading

netlify bot commented Jun 13, 2024 •

edited

Loading

netlify bot commented Jun 13, 2024 •

edited

Loading

coderabbitai bot commented Jun 13, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

kemuru Jun 17, 2024

kemuru Jun 17, 2024 •

edited

Loading

kemuru left a comment •

edited

Loading

kemuru left a comment

codeclimate bot commented Jun 17, 2024

feat(web): Evidence: display submission timestamp #1617

feat(web): Evidence: display submission timestamp #1617

Conversation

ShubhamParkhi commented Jun 13, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

netlify bot commented Jun 13, 2024 • edited Loading

✅ Deploy Preview for kleros-v2 ready!

netlify bot commented Jun 13, 2024 • edited Loading

‼️ Deploy request for kleros-v2-neo rejected.

netlify bot commented Jun 13, 2024 • edited Loading

❌ Deploy Preview for kleros-v2-university failed. Why did it fail? →

coderabbitai bot commented Jun 13, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

kemuru Jun 17, 2024

Choose a reason for hiding this comment

kemuru Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

kemuru left a comment • edited Loading

Choose a reason for hiding this comment

kemuru left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jun 17, 2024

ShubhamParkhi commented Jun 13, 2024 •

edited by pr-codex bot

Loading

netlify bot commented Jun 13, 2024 •

edited

Loading

netlify bot commented Jun 13, 2024 •

edited

Loading

netlify bot commented Jun 13, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

kemuru Jun 17, 2024 •

edited

Loading

kemuru left a comment •

edited

Loading