-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolver miniguides #1636
Conversation
WalkthroughThe changes focus on improving the styling and UI components across multiple files in the Changes
Poem
Tip AI model upgrade
|
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-neo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kleros-v2-university ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- web/src/components/Popup/MiniGuides/DisputeResolver/CrowdfundAppeal.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/DisputeResolver/index.tsx (1 hunks)
- web/src/pages/Resolver/index.tsx (4 hunks)
Additional comments not posted (3)
web/src/components/Popup/MiniGuides/DisputeResolver/CrowdfundAppeal.tsx (1)
1-40
: LGTM!The
CrowdfundAppeal
component is well-structured and leverages styled-components effectively to apply theme-based styling to the SVG.web/src/components/Popup/MiniGuides/DisputeResolver/index.tsx (1)
1-39
: LGTM!The
DisputeResolver
component is well-structured and integrates seamlessly with thePageContentsTemplate
component. The prop types and usage are appropriate.web/src/pages/Resolver/index.tsx (1)
Line range hint
5-90
: LGTM!The
DisputeResolver
component uses theuseToggle
hook effectively to manage the state ofisDisputeResolverMiniGuideOpen
. The integration of theHowItWorks
component with theResolver
component as theMiniGuideComponent
is well-implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (6)
web/src/assets/svgs/mini-guides/dispute-resolver/parameters.svg
is excluded by!**/*.svg
web/src/assets/svgs/mini-guides/dispute-resolver/parties.svg
is excluded by!**/*.svg
web/src/assets/svgs/mini-guides/dispute-resolver/policy.svg
is excluded by!**/*.svg
web/src/assets/svgs/mini-guides/dispute-resolver/start-a-case.svg
is excluded by!**/*.svg
web/src/assets/svgs/mini-guides/dispute-resolver/voting-options.svg
is excluded by!**/*.svg
web/src/assets/svgs/mini-guides/dispute-resolver/well-done.svg
is excluded by!**/*.svg
Files selected for processing (8)
- web/src/components/Popup/MiniGuides/DisputeResolver/Parameters.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/DisputeResolver/Parties.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/DisputeResolver/Policy.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/DisputeResolver/StartACase.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/DisputeResolver/VotingOptions.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/DisputeResolver/WellDone.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/DisputeResolver/index.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx (2 hunks)
Files skipped from review due to trivial changes (2)
- web/src/components/Popup/MiniGuides/DisputeResolver/Parameters.tsx
- web/src/components/Popup/MiniGuides/DisputeResolver/StartACase.tsx
Files skipped from review as they are similar to previous changes (1)
- web/src/components/Popup/MiniGuides/DisputeResolver/index.tsx
Additional context used
Biome
web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx
[error] 71-71: Avoid passing content using the dangerouslySetInnerHTML prop.
Setting content using code can expose users to cross-site scripting (XSS) attacks
(lint/security/noDangerouslySetInnerHtml)
Additional comments not posted (5)
web/src/components/Popup/MiniGuides/DisputeResolver/Policy.tsx (1)
1-31
: Good use of styled-components and theme variables.The use of styled-components and theme variables for styling the SVG ensures consistency and maintainability.
web/src/components/Popup/MiniGuides/DisputeResolver/Parties.tsx (1)
1-31
: Good use of styled-components and theme variables.The use of styled-components and theme variables for styling the SVG ensures consistency and maintainability.
web/src/components/Popup/MiniGuides/DisputeResolver/VotingOptions.tsx (1)
1-35
: Good use of styled-components and theme variables.The use of styled-components and theme variables for styling the SVG ensures consistency and maintainability.
web/src/components/Popup/MiniGuides/DisputeResolver/WellDone.tsx (1)
1-47
: Good use of styled-components and theme variables.The use of styled-components and theme variables for styling the SVG ensures consistency and maintainability.
web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx (1)
45-51
: LGTM!The
StyledParagraph
component is well-defined with appropriate styling attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- web/src/components/Popup/MiniGuides/Onboarding/index.tsx (5 hunks)
- web/src/pages/Resolver/Briefing/Title.tsx (1 hunks)
- web/src/pages/Resolver/Parameters/Category.tsx (1 hunks)
- web/src/pages/Resolver/Parameters/Court.tsx (1 hunks)
- web/src/pages/Resolver/Parameters/Jurors.tsx (1 hunks)
- web/src/pages/Resolver/Policy/index.tsx (1 hunks)
- web/src/pages/Resolver/Timeline.tsx (1 hunks)
- web/src/pages/Resolver/index.tsx (5 hunks)
Files skipped from review due to trivial changes (3)
- web/src/pages/Resolver/Parameters/Court.tsx
- web/src/pages/Resolver/Parameters/Jurors.tsx
- web/src/pages/Resolver/Timeline.tsx
Files skipped from review as they are similar to previous changes (1)
- web/src/pages/Resolver/index.tsx
Additional comments not posted (10)
web/src/pages/Resolver/Briefing/Title.tsx (1)
19-19
: LGTM!The addition of responsive padding to the
Container
styled component is correct and consistent with the project's styling conventions.web/src/pages/Resolver/Parameters/Category.tsx (1)
19-19
: LGTM!The addition of responsive padding to the
Container
styled component is correct and consistent with the project's styling conventions.web/src/pages/Resolver/Policy/index.tsx (1)
23-23
: LGTM!The addition of responsive padding to the
Container
styled component is correct and consistent with the project's styling conventions.web/src/components/Popup/MiniGuides/Onboarding/index.tsx (7)
10-10
: LGTM!The addition of the new import for
DisputeResolver
is correct and consistent with the project's conventions.
39-46
: LGTM!The addition of the new link for
Dispute Resolver
in theleftPageContents
array is correct and consistent with the project's conventions.
62-62
: LGTM!The addition of the new state variable
isDisputeResolverMiniGuideOpen
is correct and consistent with the project's conventions.
69-70
: LGTM!The update to the
isAnyMiniGuideOpen
variable to includeisDisputeResolverMiniGuideOpen
is correct and consistent with the project's conventions.
77-78
: LGTM!The update to the
canCloseOnboarding
variable to includeisDisputeResolverMiniGuideOpen
is correct and consistent with the project's conventions.
91-92
: LGTM!The update to the
toggleSubMiniGuide
function to includeDispute Resolver
is correct and consistent with the project's conventions.
113-113
: LGTM!The update to the return statement to include the
DisputeResolver
component is correct and consistent with the project's conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- web/src/components/Popup/MiniGuides/DisputeResolver/index.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- web/src/components/Popup/MiniGuides/DisputeResolver/index.tsx
- web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- web/src/components/Popup/MiniGuides/MainStructureTemplate.tsx (2 hunks)
- web/src/pages/Resolver/index.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- web/src/pages/Resolver/index.tsx
Additional comments not posted (2)
web/src/components/Popup/MiniGuides/MainStructureTemplate.tsx (2)
Line range hint
14-14
: LGTM!The addition of padding-bottom using
responsiveSize
enhances the responsiveness of theLeftContainer
component.
182-182
: LGTM!The addition of padding using
responsiveSize
enhances the responsiveness of theRightContainer
component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/src/components/Popup/MiniGuides/Onboarding/index.tsx (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- web/src/components/Popup/MiniGuides/Onboarding/index.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- web/src/components/Popup/MiniGuides/JurorLevels.tsx (1 hunks)
- web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
- web/src/components/Popup/MiniGuides/JurorLevels.tsx
Files skipped from review as they are similar to previous changes (1)
- web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx (2 hunks)
- web/src/pages/Resolver/Briefing/Title.tsx (1 hunks)
- web/src/pages/Resolver/Parameters/Category.tsx (1 hunks)
- web/src/pages/Resolver/Parameters/Court.tsx (1 hunks)
- web/src/pages/Resolver/Parameters/Jurors.tsx (3 hunks)
- web/src/pages/Resolver/Policy/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- web/src/components/Popup/MiniGuides/PageContentsTemplate.tsx
- web/src/pages/Resolver/Briefing/Title.tsx
- web/src/pages/Resolver/Parameters/Category.tsx
- web/src/pages/Resolver/Parameters/Court.tsx
- web/src/pages/Resolver/Parameters/Jurors.tsx
- web/src/pages/Resolver/Policy/index.tsx
…ure to the mini guides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (2)
- web/package.json (1 hunks)
- web/src/components/Popup/MiniGuides/MainStructureTemplate.tsx (3 hunks)
Files skipped from review due to trivial changes (1)
- web/package.json
Files skipped from review as they are similar to previous changes (1)
- web/src/components/Popup/MiniGuides/MainStructureTemplate.tsx
Code Climate has analyzed commit 062af96 and detected 9 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/src/components/Popup/MiniGuides/MainStructureTemplate.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- web/src/components/Popup/MiniGuides/MainStructureTemplate.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR-Codex overview
The focus of this PR is to update styles and dependencies related to UI components in the project.
Detailed summary
@kleros/ui-components-library
to version2.14.0
Summary by CodeRabbit
New Features
Style
padding-bottom
styles to various components for consistent layout and spacing across different pages.Refactor
Close
styled component from the MiniGuides popup, streamlining the close action logic.Chores
@kleros/ui-components-library
version to^2.14.0
inpackage.json
.