Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): disable buttons if insufficient balance #1720

Merged
merged 3 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions web/src/components/ErrorButtonMessage.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import styled from "styled-components";

export const ErrorButtonMessage = styled.div`
display: flex;
align-items: center;
gap: 4px;
justify-content: center;
margin: 12px;
color: ${({ theme }) => theme.error};
font-size: 14px;
`;
14 changes: 14 additions & 0 deletions web/src/components/StyledIcons/ClosedCircleIcon.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import React from "react";
import styled from "styled-components";
import ClosedCircle from "svgs/icons/close-circle.svg";

const StyledClosedCircle = styled(ClosedCircle)`
path {
fill: ${({ theme }) => theme.error};
}
`;

const ClosedCircleIcon: React.FC = () => {
return <StyledClosedCircle />;
};
export default ClosedCircleIcon;
71 changes: 43 additions & 28 deletions web/src/pages/Cases/CaseDetails/Appeal/Classic/Fund.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import { isUndefined } from "utils/index";
import { wrapWithToast } from "utils/wrapWithToast";

import { EnsureChain } from "components/EnsureChain";
import { ErrorButtonMessage } from "components/ErrorButtonMessage";
import ClosedCircleIcon from "components/StyledIcons/ClosedCircleIcon";

const Container = styled.div`
display: flex;
Expand Down Expand Up @@ -46,6 +48,7 @@ const StyledButton = styled(Button)`
const StyledLabel = styled.label`
align-self: flex-start;
`;

const useNeedFund = () => {
const { loserSideCountdown } = useCountdownContext();
const { fundedChoices, winningChoice } = useFundingContext();
Expand All @@ -59,20 +62,24 @@ const useNeedFund = () => {
return needFund;
};

const useFundAppeal = (parsedAmount) => {
const useFundAppeal = (parsedAmount, insufficientBalance) => {
const { id } = useParams();
const { selectedOption } = useSelectedOptionContext();
const { data: fundAppealConfig, isError } = useSimulateDisputeKitClassicFundAppeal({
const {
data: fundAppealConfig,
isLoading,
isError,
} = useSimulateDisputeKitClassicFundAppeal({
query: {
enabled: !isUndefined(id) && !isUndefined(selectedOption),
enabled: !isUndefined(id) && !isUndefined(selectedOption) && !insufficientBalance,
},
args: [BigInt(id ?? 0), BigInt(selectedOption ?? 0)],
value: parsedAmount,
});

const { writeContractAsync: fundAppeal } = useWriteDisputeKitClassicFundAppeal();

return { fundAppeal, fundAppealConfig, isError };
return { fundAppeal, fundAppealConfig, isLoading, isError };
};

interface IFund {
Expand All @@ -98,12 +105,15 @@ const Fund: React.FC<IFund> = ({ amount, setAmount, setIsOpen }) => {

const parsedAmount = useParsedAmount(debouncedAmount as `${number}`);

const { fundAppealConfig, fundAppeal, isError } = useFundAppeal(parsedAmount);
const insufficientBalance = useMemo(() => {
return balance && balance.value < parsedAmount;
}, [balance, parsedAmount]);

const { fundAppealConfig, fundAppeal, isLoading, isError } = useFundAppeal(parsedAmount, insufficientBalance);

const isFundDisabled = useMemo(
() =>
isDisconnected || isSending || !balance || parsedAmount > balance.value || Number(parsedAmount) <= 0 || isError,
[isDisconnected, isSending, balance, parsedAmount, isError]
() => isDisconnected || isSending || !balance || insufficientBalance || Number(parsedAmount) <= 0 || isError,
[isDisconnected, isSending, balance, insufficientBalance, parsedAmount, isError]
);

return needFund ? (
Expand All @@ -118,28 +128,33 @@ const Fund: React.FC<IFund> = ({ amount, setAmount, setIsOpen }) => {
placeholder="Amount to fund"
/>
<EnsureChain>
<StyledButton
disabled={isFundDisabled}
isLoading={isSending}
text={isDisconnected ? "Connect to Fund" : "Fund"}
onClick={() => {
if (fundAppeal && fundAppealConfig && publicClient) {
setIsSending(true);
wrapWithToast(async () => await fundAppeal(fundAppealConfig.request), publicClient)
.then((res) => {
res.status && setIsOpen(true);
})
.finally(() => {
setIsSending(false);
});
}
}}
/>
<div>
<StyledButton
disabled={isFundDisabled}
isLoading={(isSending || isLoading) && !insufficientBalance}
text={isDisconnected ? "Connect to Fund" : "Fund"}
onClick={() => {
if (fundAppeal && fundAppealConfig && publicClient) {
setIsSending(true);
wrapWithToast(async () => await fundAppeal(fundAppealConfig.request), publicClient)
.then((res) => {
res.status && setIsOpen(true);
})
.finally(() => {
setIsSending(false);
});
}
}}
/>
{insufficientBalance && (
<ErrorButtonMessage>
<ClosedCircleIcon /> Insufficient balance
</ErrorButtonMessage>
)}
</div>
</EnsureChain>
</Container>
) : (
<></>
);
) : null;
};

export default Fund;
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@ import { isUndefined } from "src/utils";
import { Phases } from "components/Phase";

import { IBaseMaintenanceButton } from ".";
import { Link } from "react-router-dom";

const StyledButton = styled(Button)`
width: 100%;
`;

const StyledLabel = styled.label``;
interface IDrawButton extends IBaseMaintenanceButton {
numberOfVotes?: string;
period?: string;
Expand All @@ -40,6 +42,11 @@ const DrawButton: React.FC<IDrawButton> = ({ id, numberOfVotes, setIsOpen, perio
[maintenanceData, isDrawn, phase, period]
);

const needToPassPhase = useMemo(
() => !isUndefined(maintenanceData) && !isDrawn && period === Period.Evidence && phase !== Phases.drawing,
[maintenanceData, isDrawn, phase, period]
);

const {
data: drawConfig,
isLoading: isLoadingConfig,
Expand Down Expand Up @@ -68,7 +75,17 @@ const DrawButton: React.FC<IDrawButton> = ({ id, numberOfVotes, setIsOpen, perio
setIsOpen(false);
});
};
return <StyledButton text="Draw" small isLoading={isLoading} disabled={isDisabled} onClick={handleClick} />;
return (
<>
{needToPassPhase ? (
<StyledLabel>
Jurors can be drawn in <small>drawing</small> phase.
<br /> Pass phase <Link to="/courts/1/purpose/#maintenance">here</Link>.
</StyledLabel>
) : null}
<StyledButton text="Draw" small isLoading={isLoading} disabled={isDisabled} onClick={handleClick} />
</>
);
};

export default DrawButton;
7 changes: 6 additions & 1 deletion web/src/pages/Courts/StakeMaintenanceButton/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from "react";
import React, { useEffect, useState } from "react";
import styled from "styled-components";

import DottedMenuButton from "components/DottedMenuButton";
Expand Down Expand Up @@ -47,6 +47,11 @@ interface IStakeMaintenanceButtons {
const StakeMaintenanceButtons: React.FC<IStakeMaintenanceButtons> = ({ className }) => {
const [isOpen, setIsOpen] = useState(false);

useEffect(() => {
const openDefault = location.hash.includes("#maintenance");
if (openDefault) setIsOpen(true);
}, []);

const toggle = () => setIsOpen((prevValue) => !prevValue);
return (
<Container {...{ className }}>
Expand Down
72 changes: 45 additions & 27 deletions web/src/pages/Resolver/NavigationButtons/SubmitDisputeButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useMemo, useState } from "react";
import styled from "styled-components";

import { Log, decodeEventLog, parseAbi } from "viem";
import { usePublicClient } from "wagmi";
import { useAccount, useBalance, usePublicClient } from "wagmi";

import { Button } from "@kleros/ui-components-library";

Expand All @@ -20,6 +20,9 @@ import { wrapWithToast } from "utils/wrapWithToast";
import { EnsureChain } from "components/EnsureChain";
import Popup, { PopupType } from "components/Popup";

import { ErrorButtonMessage } from "components/ErrorButtonMessage";
import ClosedCircleIcon from "components/StyledIcons/ClosedCircleIcon";

const StyledButton = styled(Button)``;

const SubmitDisputeButton: React.FC = () => {
Expand All @@ -31,10 +34,18 @@ const SubmitDisputeButton: React.FC = () => {
const { disputeTemplate, disputeData, resetDisputeData, isSubmittingCase, setIsSubmittingCase } =
useNewDisputeContext();

const { address } = useAccount();
const { data: userBalance, isLoading: isBalanceLoading } = useBalance({ address });

const insufficientBalance = useMemo(() => {
const arbitrationCost = disputeData.arbitrationCost ? BigInt(disputeData.arbitrationCost) : BigInt(0);
return userBalance && userBalance.value < arbitrationCost;
}, [userBalance, disputeData]);

// TODO: decide which dispute kit to use
const { data: submitCaseConfig } = useSimulateDisputeResolverCreateDisputeForTemplate({
query: {
enabled: isTemplateValid(disputeTemplate),
enabled: !insufficientBalance && isTemplateValid(disputeTemplate),
},
args: [
prepareArbitratorExtradata(disputeData.courtId ?? "1", disputeData.numberOfJurors ?? "", 1),
Expand All @@ -48,37 +59,44 @@ const SubmitDisputeButton: React.FC = () => {
const { writeContractAsync: submitCase } = useWriteDisputeResolverCreateDisputeForTemplate();

const isButtonDisabled = useMemo(
() => isSubmittingCase || !isTemplateValid(disputeTemplate),
[isSubmittingCase, disputeTemplate]
() => isSubmittingCase || !isTemplateValid(disputeTemplate) || isBalanceLoading || insufficientBalance,
[isSubmittingCase, insufficientBalance, isBalanceLoading, disputeTemplate]
);

return (
<>
{" "}
<EnsureChain>
<StyledButton
text="Submit the case"
disabled={isButtonDisabled}
isLoading={isSubmittingCase}
onClick={() => {
if (submitCaseConfig) {
setIsSubmittingCase(true);
wrapWithToast(async () => await submitCase(submitCaseConfig.request), publicClient)
.then((res) => {
if (res.status && !isUndefined(res.result)) {
const id = retrieveDisputeId(res.result.logs[1]);
setDisputeId(Number(id));
setCourtId(disputeData.courtId ?? "1");
setIsPopupOpen(true);
resetDisputeData();
}
})
.finally(() => {
setIsSubmittingCase(false);
});
}
}}
/>
<div>
<StyledButton
text="Submit the case"
disabled={isButtonDisabled}
isLoading={(isSubmittingCase || isBalanceLoading) && !insufficientBalance}
onClick={() => {
if (submitCaseConfig) {
setIsSubmittingCase(true);
wrapWithToast(async () => await submitCase(submitCaseConfig.request), publicClient)
.then((res) => {
if (res.status && !isUndefined(res.result)) {
const id = retrieveDisputeId(res.result.logs[1]);
setDisputeId(Number(id));
setCourtId(disputeData.courtId ?? "1");
setIsPopupOpen(true);
resetDisputeData();
}
})
.finally(() => {
setIsSubmittingCase(false);
});
}
}}
/>
{insufficientBalance && (
<ErrorButtonMessage>
<ClosedCircleIcon /> Insufficient balance
</ErrorButtonMessage>
)}
</div>
</EnsureChain>
{isPopupOpen && disputeId && (
<Popup
Expand Down
Loading