Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update footer socials #1731

Merged
merged 2 commits into from
Nov 4, 2024
Merged

feat: update footer socials #1731

merged 2 commits into from
Nov 4, 2024

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Nov 2, 2024

PR-Codex overview

This PR focuses on adding a new YouTube social media entry to the project and includes the corresponding SVG asset for the YouTube logo.

Detailed summary

  • Added youtube.svg asset to both web/src/assets/svgs/socialmedia/ and web-devtools/src/assets/svgs/socialmedia/.
  • Imported YouTubeLogo in socialmedia.tsx files.
  • Added youtube entry to the socialmedia object with URL https://youtube.com/@kleros_io.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added a new YouTube entry to the social media links, allowing users to connect with our content on this platform.
  • Changes
    • Removed entries for Etherscan, Ghost Blog, Reddit, and Snapshot from the social media links.
    • Repositioned existing entries for Discord, GitHub, and Telegram within the social media links.

Copy link
Contributor

coderabbitai bot commented Nov 2, 2024

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • web-devtools/src/assets/svgs/socialmedia/youtube.svg is excluded by !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes involve updates to the socialmedia object in two files: web-devtools/src/consts/socialmedia.tsx and web/src/consts/socialmedia.tsx. Several social media entries, specifically for Etherscan, Ghost Blog, Reddit, and Snapshot, have been removed. A new entry for YouTube has been added, which includes an icon and a URL. The existing entries for Discord, GitHub, and Telegram remain, with some being repositioned within the object while retaining their original properties.

Changes

File Change Summary
web-devtools/src/consts/socialmedia.tsx Removed entries: Etherscan, Ghost Blog, Reddit, Snapshot; Added entry: YouTube with icon and URL.
web/src/consts/socialmedia.tsx Removed entries: Etherscan, Ghost Blog, Reddit, Snapshot; Added entry: YouTube with icon and URL; Telegram and GitHub repositioned.

Poem

In the fields of code, a change took flight,
Old friends departed, new ones in sight.
YouTube hops in with a logo so bright,
While Discord and GitHub hold on tight.
A social media dance, a digital delight! 🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for kleros-v2-university ready!

Name Link
🔨 Latest commit 7c3865b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/67259e8472cd7b00075a29ec
😎 Deploy Preview https://deploy-preview-1731--kleros-v2-university.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for kleros-v2-neo ready!

Name Link
🔨 Latest commit 7c3865b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/67259e8426c04600080a1f9b
😎 Deploy Preview https://deploy-preview-1731--kleros-v2-neo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for kleros-v2-testnet ready!

Name Link
🔨 Latest commit 7c3865b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet/deploys/67259e84cc5d49000856a881
😎 Deploy Preview https://deploy-preview-1731--kleros-v2-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for kleros-v2-testnet-devtools ready!

Name Link
🔨 Latest commit 7c3865b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/67259e84ff018200082e0a22
😎 Deploy Preview https://deploy-preview-1731--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
web-devtools/src/consts/socialmedia.tsx (1)

Line range hint 10-34: Consider adding TypeScript types and documentation.

To improve maintainability and code clarity, consider:

  1. Adding a TypeScript interface for the social media entries
  2. Adding a comment explaining the ordering rationale

Add the following above the socialmedia object:

interface SocialMediaEntry {
  icon: React.ReactElement;
  url: string;
}

/**
 * Social media links ordered by platform priority and user engagement.
 */
export const socialmedia: Record<string, SocialMediaEntry> = {
web/src/consts/socialmedia.tsx (1)

Line range hint 11-34: Consider organizing social media entries alphabetically

While the current ordering works, consider sorting the entries alphabetically for easier maintenance and scanning. This would help maintain consistency as new platforms are added or removed in the future.

Here's a suggested reordering:

 export const socialmedia = {
   discord: {
     icon: <DiscordLogo />,
     url: "https://discord.com/invite/MhXQGCyHd9",
   },
   github: {
     icon: <GithubLogo />,
     url: "https://github.com/kleros",
   },
   linkedin: {
     icon: <LinkedinLogo />,
     url: "https://www.linkedin.com/company/kleros/",
   },
   telegram: {
     icon: <TelegramLogo />,
     url: "https://t.me/kleros",
   },
   x: {
     icon: <XLogo />,
     url: "https://x.com/kleros_io",
   },
   youtube: {
     icon: <YouTubeLogo />,
     url: "https://youtube.com/@kleros_io",
   },
 };
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 95965a0 and 4e45f3b.

⛔ Files ignored due to path filters (1)
  • web/src/assets/svgs/socialmedia/youtube.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • web-devtools/src/consts/socialmedia.tsx (1 hunks)
  • web/src/consts/socialmedia.tsx (1 hunks)
🔇 Additional comments (4)
web-devtools/src/consts/socialmedia.tsx (2)

6-6: LGTM: Import statement changes are consistent.

The addition of the YouTube logo import and removal of unused logo imports align well with the social media entries modifications.


Line range hint 11-34: LGTM: Social media entries are well-structured.

The social media object maintains consistent formatting and structure across all entries. The new YouTube entry follows the established pattern.

Let's verify that all social media URLs are accessible:

web/src/consts/socialmedia.tsx (2)

6-6: LGTM: YouTube logo import follows project conventions


23-26: LGTM: YouTube entry follows consistent structure

The new YouTube entry maintains consistency with other social media entries in terms of structure and URL format.

coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 2, 2024
Copy link

codeclimate bot commented Nov 2, 2024

Code Climate has analyzed commit 7c3865b and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

Copy link

sonarqubecloud bot commented Nov 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
92.3% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Nov 4, 2024
Merged via the queue into dev with commit b6b7c17 Nov 4, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants