Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update-next #1758

Closed
wants to merge 1 commit into from
Closed

chore: update-next #1758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@web3modal/wagmi": "^5.1.11",
"graphql": "^16.9.0",
"graphql-request": "^7.1.0",
"next": "14.2.14",
"next": "^15.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Version mismatch with eslint-config-next

The project is using eslint-config-next@^14.2.15 but upgrading to next@^15.0.3. These versions should match to ensure proper linting rules.

Apply this change:

-    "eslint-config-next": "^14.2.15",
+    "eslint-config-next": "^15.0.3",

Committable suggestion skipped: line range outside the PR's diff.

💡 Codebase verification

⚠️ Potential issue

⚠️ Version mismatch between Next.js and eslint-config-next

The project is using Next.js 15.0.3 but eslint-config-next is still on 14.2.15. This version mismatch could lead to linting issues. However, the project is already using the App Router pattern which is compatible with Next.js 15. Please:

  1. Update eslint-config-next to version 15:
"eslint-config-next": "^15.0.3"
  1. Keep the caret (^) version constraint for Next.js as it's appropriate for framework dependencies within the same major version.
🔗 Analysis chain

⚠️ Major version upgrade requires careful review

This is a major version upgrade from Next.js 14 to 15, which introduces breaking changes. Please ensure:

  1. Review of the Next.js 15 migration guide
  2. Testing of all application features
  3. CI pipeline passes with the new version

Let me gather more information about the Next.js configuration and dependencies to provide a more comprehensive verification.

Let me check the Next.js configuration and app structure to verify potential breaking changes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for Next.js specific patterns that might need updates in v15
echo "Checking for potential breaking changes..."

# Check for usage of deprecated features
rg -l "getInitialProps|getServerSideProps|getStaticProps|getStaticPaths" 

# Check for custom server implementations
fd "server.js|server.ts"

# Check for custom webpack config
fd "next.config.js|next.config.ts"

Length of output: 233

Script:

#!/bin/bash
# Check package.json for Next.js related dependencies and configurations
cat web-devtools/package.json

# Look for any Next.js specific files and components
fd -e tsx -e jsx -e js -e ts

# Check for app directory structure (Next.js 13+ feature)
fd -t d "app"

# Look for pages directory (traditional Next.js structure)
fd -t d "pages"

Length of output: 26687

Script:

#!/bin/bash
# Check Next.js configuration
cat web-devtools/next.config.js 2>/dev/null || echo "No next.config.js found"

# Check for app directory usage
fd -t f . web-devtools/src/app/

# Check package.json for Next.js related dependencies
grep -A 5 -B 5 "next\":" web-devtools/package.json

Length of output: 1773

"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-markdown": "^8.0.7",
Expand Down
3 changes: 2 additions & 1 deletion web-devtools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
"svgs*": [
"assets/svgs*"
]
}
},
"target": "ES2017"
},
"include": [
"svgr.d.ts",
Expand Down
Loading
Loading