fix(web): fix-overlay-scroll-lock #1788

Harman-singh-waraich · 2024-12-13T05:11:56Z

PR-Codex overview

This PR focuses on the integration of the useLockOverlayScroll hook into the StakeWithdrawButton component while removing it from the StakeWithdrawPopup component. This change likely aims to manage scroll behavior more effectively during the withdrawal process.

Detailed summary

Removed useLockOverlayScroll(true) from the StakeWithdrawPopup component in index.tsx.
Added useLockOverlayScroll(isPopupOpen) to the StakeWithdrawButton component in StakeWithdrawButton.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- Added scroll locking functionality to the Stake Withdraw button, enhancing user experience by preventing background scrolling when the popup is open.
Bug Fixes
- Adjusted scroll behavior of the Stake Withdraw popup, allowing underlying content to scroll while the popup is active.

coderabbitai · 2024-12-13T05:12:05Z

Walkthrough

The changes introduce the useLockOverlayScroll hook into the StakeWithdrawButton component to manage scroll behavior when a popup is open, preventing background scrolling. In contrast, the StakeWithdrawPopup component removes the previous invocation of this hook, allowing background content to scroll while the popup is active. The overall structure and functionality of both components remain largely unchanged.

Changes

File	Change Summary
`web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx`	Added `useLockOverlayScroll` hook to manage scroll behavior when the popup is open.
`web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawPopup/index.tsx`	Removed `useLockOverlayScroll` hook, allowing underlying content to scroll while the popup is active.

Possibly related PRs

fix(web): display-stake-button-error #1742: Modifies the StakeWithdrawButton component by adding error handling features.
Refactor/stake abort controller #1783: Introduces an abort controller to the StakeWithdrawButton, enhancing its functionality.
fix(web): stake-button-disabling #1787: Refines the logic for enabling and disabling the StakeWithdrawButton.

Suggested labels

Type: Enhancement :sparkles:, Package: Web

Suggested reviewers

alcercu

🐰 In the meadow, where bunnies play,
A button now locks the scroll away.
With popups bright, the view stays clear,
While hopping around, we have no fear!
So let’s celebrate, with a joyful cheer! 🌼

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6abacc8 and 4776c31.

📒 Files selected for processing (2)

web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx (2 hunks)
web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawPopup/index.tsx (0 hunks)

💤 Files with no reviewable changes (1)

web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawPopup/index.tsx

🧰 Additional context used

📓 Learnings (1)

web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx (1)

Learnt from: Harman-singh-waraich
PR: kleros/kleros-v2#1775
File: web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx:0-0
Timestamp: 2024-12-09T12:36:59.441Z
Learning: In the `StakeWithdrawButton` component, the transaction flow logic is tightly linked to component updates, so extracting it into a custom hook does not provide significant benefits.

🔇 Additional comments (2)

web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx (2)

19-19: LGTM!

The import statement is clean and follows the existing import grouping pattern.

59-59: LGTM! Clean integration of scroll lock.

The useLockOverlayScroll hook is properly integrated with the isPopupOpen state, which ensures scroll locking is synchronized with the popup's visibility state. The implementation follows React hooks best practices.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-13T05:12:15Z

✅ Deploy Preview for kleros-v2-neo ready!

Name	Link
🔨 Latest commit	`4776c31`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-neo/deploys/675bc21f87ad330008a84899
😎 Deploy Preview	https://deploy-preview-1788--kleros-v2-neo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-12-13T05:12:17Z

❌ Deploy Preview for kleros-v2-testnet-devtools failed. Why did it fail? →

Name	Link
🔨 Latest commit	`4776c31`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/675bc21fa531980008c88d33

netlify · 2024-12-13T05:12:17Z

✅ Deploy Preview for kleros-v2-university ready!

Name	Link
🔨 Latest commit	`4776c31`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/675bc21fd0881c0008d45abc
😎 Deploy Preview	https://deploy-preview-1788--kleros-v2-university.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codeclimate · 2024-12-13T05:12:42Z

Code Climate has analyzed commit 4776c31 and detected 0 issues on this pull request.

View more on Code Climate.

sonarqubecloud · 2024-12-13T05:14:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

netlify · 2024-12-13T05:14:37Z

✅ Deploy Preview for kleros-v2-testnet ready!

Name	Link
🔨 Latest commit	`4776c31`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet/deploys/675bc21f39e56e0008780f91
😎 Deploy Preview	https://deploy-preview-1788--kleros-v2-testnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alcercu

lgtm

fix(web): fix-overlay-scroll-lock

Verified

This commit was signed with the committer’s verified signature.

renovate-bot Mend Renovate

GPG key ID: 81C63AE1C224182B

Verified
Learn about vigilant mode

Loading
Loading status checks…

4776c31

coderabbitai bot approved these changes Dec 13, 2024

View reviewed changes

alcercu approved these changes Dec 13, 2024

View reviewed changes

alcercu added this pull request to the merge queue Dec 13, 2024

Merged via the queue into dev with commit 4d7f96c Dec 13, 2024
25 of 30 checks passed

This was referenced Dec 13, 2024

chore: ui improvements (detailed inside) #1786

Merged

feat: update ui library, abstract hover transition style, update favicon, add more hovers #1792

Merged

fix(web): stake-input-error-display #1797

Merged

coderabbitai bot mentioned this pull request Feb 4, 2025

refactor(web): jurors-page-scroll #1885

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): fix-overlay-scroll-lock #1788

fix(web): fix-overlay-scroll-lock #1788

Harman-singh-waraich commented Dec 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 13, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Dec 13, 2024 •

edited

Loading

netlify bot commented Dec 13, 2024 •

edited

Loading

netlify bot commented Dec 13, 2024 •

edited

Loading

codeclimate bot commented Dec 13, 2024

sonarqubecloud bot commented Dec 13, 2024

netlify bot commented Dec 13, 2024 •

edited

Loading

alcercu left a comment

fix(web): fix-overlay-scroll-lock #1788

fix(web): fix-overlay-scroll-lock #1788

Conversation

Harman-singh-waraich commented Dec 13, 2024 • edited by coderabbitai bot Loading

PR-Codex overview

Detailed summary

Summary by CodeRabbit

coderabbitai bot commented Dec 13, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Dec 13, 2024 • edited Loading

✅ Deploy Preview for kleros-v2-neo ready!

netlify bot commented Dec 13, 2024 • edited Loading

❌ Deploy Preview for kleros-v2-testnet-devtools failed. Why did it fail? →

netlify bot commented Dec 13, 2024 • edited Loading

✅ Deploy Preview for kleros-v2-university ready!

codeclimate bot commented Dec 13, 2024

sonarqubecloud bot commented Dec 13, 2024

Quality Gate passed

netlify bot commented Dec 13, 2024 • edited Loading

✅ Deploy Preview for kleros-v2-testnet ready!

alcercu left a comment

Choose a reason for hiding this comment

Harman-singh-waraich commented Dec 13, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 13, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Dec 13, 2024 •

edited

Loading

netlify bot commented Dec 13, 2024 •

edited

Loading

netlify bot commented Dec 13, 2024 •

edited

Loading

netlify bot commented Dec 13, 2024 •

edited

Loading