fix(web): arbitraion-cost-decimals #1887

Harman-singh-waraich · 2025-02-06T14:10:23Z

PR-Codex overview

This PR updates the arbitrationFee calculation in the Jurors.tsx file to use a precision of 18 decimal places instead of 5, ensuring more accurate representation of Ethereum values.

Detailed summary

Changed the precision of arbitrationFee from 5 to 18 decimal places in the formatETH function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Adjusted the arbitration fee display to use extended decimal precision, ensuring users view a more accurate fee value.

coderabbitai · 2025-02-06T14:10:33Z

Walkthrough

The change updates the precision used for calculating the arbitration fee in the Jurors component. Specifically, the formatETH function is now called with a precision of 18 instead of 5. This modification affects how the arbitration fee is formatted and displayed to the user, without altering the remaining component logic.

Changes

File	Change Summary
`web/src/pages/Resolver/Parameters/Jurors.tsx`	Updated `formatETH` call in the arbitration fee calculation from `formatETH(data, 5)` to `formatETH(data, 18)`

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant J as Jurors Component
    participant F as formatETH Function

    U->>J: Request arbitration fee display
    J->>F: Call formatETH(data ?? BigInt(0), 18)
    F-->>J: Return formatted arbitration fee
    J-->>U: Display arbitration fee with 18 decimal precision

Poem

I'm a rabbit who loves to hop around,
In code, a new precision has been found.
From 5 to 18, the decimals now gleam,
A carrot of progress in every stream.
Hoppy changes, a delightful scene!
🥕🐇

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b472514 and 920bf9f.

📒 Files selected for processing (1)

web/src/pages/Resolver/Parameters/Jurors.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (15)

GitHub Check: Redirect rules - kleros-v2-testnet-devtools
GitHub Check: Header rules - kleros-v2-testnet-devtools
GitHub Check: Pages changed - kleros-v2-testnet-devtools
GitHub Check: Redirect rules - kleros-v2-neo
GitHub Check: Redirect rules - kleros-v2-testnet
GitHub Check: Redirect rules - kleros-v2-testnet
GitHub Check: Header rules - kleros-v2-testnet
GitHub Check: Header rules - kleros-v2-neo
GitHub Check: Header rules - kleros-v2-testnet
GitHub Check: Pages changed - kleros-v2-neo
GitHub Check: Pages changed - kleros-v2-testnet
GitHub Check: Pages changed - kleros-v2-testnet
GitHub Check: SonarCloud
GitHub Check: contracts-testing
GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

web/src/pages/Resolver/Parameters/Jurors.tsx (1)

65-65: LGTM! The change correctly aligns with ETH's standard precision.

The update to use 18 decimal places is correct as it matches ETH's standard precision (1 ETH = 10^18 wei), ensuring more accurate representation of arbitration costs.

Please verify that the UI properly handles the display of values with 18 decimal places, especially for small arbitration costs that might have many leading zeros after the decimal point.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-06T14:10:42Z

✅ Deploy Preview for kleros-v2-neo ready!

Name	Link
🔨 Latest commit	`920bf9f`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-neo/deploys/67a4c2d3d255dd000800c00a
😎 Deploy Preview	https://deploy-preview-1887--kleros-v2-neo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-02-06T14:10:42Z

✅ Deploy Preview for kleros-v2-testnet ready!

Name	Link
🔨 Latest commit	`920bf9f`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet/deploys/67a4c2d34f80830008df7c69
😎 Deploy Preview	https://deploy-preview-1887--kleros-v2-testnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-02-06T14:10:43Z

✅ Deploy Preview for kleros-v2-testnet-devtools ready!

Name	Link
🔨 Latest commit	`920bf9f`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-testnet-devtools/deploys/67a4c2d3744f31000854ce10
😎 Deploy Preview	https://deploy-preview-1887--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codeclimate · 2025-02-06T14:11:24Z

Code Climate has analyzed commit 920bf9f and detected 0 issues on this pull request.

View more on Code Climate.

sonarqubecloud · 2025-02-06T14:12:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

netlify · 2025-02-06T14:13:43Z

✅ Deploy Preview for kleros-v2-university ready!

Name	Link
🔨 Latest commit	`920bf9f`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-university/deploys/67a4c2d3c1341b00081ba991
😎 Deploy Preview	https://deploy-preview-1887--kleros-v2-university.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alcercu

lgtm

fix(web): arbitraion-cost-decimals

920bf9f

Harman-singh-waraich requested a review from a team as a code owner February 6, 2025 14:10

coderabbitai bot approved these changes Feb 6, 2025

View reviewed changes

alcercu approved these changes Feb 6, 2025

View reviewed changes

alcercu merged commit 99b1c9f into dev Feb 6, 2025
26 checks passed

alcercu deleted the fix/arbitration-cost-rounding branch February 6, 2025 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): arbitraion-cost-decimals #1887

fix(web): arbitraion-cost-decimals #1887

Harman-singh-waraich commented Feb 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 6, 2025 •

edited

Loading

netlify bot commented Feb 6, 2025 •

edited

Loading

netlify bot commented Feb 6, 2025 •

edited

Loading

codeclimate bot commented Feb 6, 2025

sonarqubecloud bot commented Feb 6, 2025

netlify bot commented Feb 6, 2025 •

edited

Loading

alcercu left a comment

fix(web): arbitraion-cost-decimals #1887

fix(web): arbitraion-cost-decimals #1887

Conversation

Harman-singh-waraich commented Feb 6, 2025 • edited by coderabbitai bot Loading

PR-Codex overview

Detailed summary

Summary by CodeRabbit

coderabbitai bot commented Feb 6, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 6, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-neo ready!

netlify bot commented Feb 6, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-testnet ready!

netlify bot commented Feb 6, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-testnet-devtools ready!

codeclimate bot commented Feb 6, 2025

sonarqubecloud bot commented Feb 6, 2025

Quality Gate passed

netlify bot commented Feb 6, 2025 • edited Loading

✅ Deploy Preview for kleros-v2-university ready!

alcercu left a comment

Choose a reason for hiding this comment

Harman-singh-waraich commented Feb 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 6, 2025 •

edited

Loading

netlify bot commented Feb 6, 2025 •

edited

Loading

netlify bot commented Feb 6, 2025 •

edited

Loading

netlify bot commented Feb 6, 2025 •

edited

Loading