Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): links to socials #673

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix(web): links to socials #673

merged 2 commits into from
Apr 10, 2023

Conversation

Arun9650
Copy link
Contributor

@Arun9650 Arun9650 commented Apr 9, 2023

close #648
i have put all the links but only 2 left as I have not found the links one is "join the community calls" and cooperative kleros.

@netlify
Copy link

netlify bot commented Apr 9, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit d27a189
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/643449bd8f84d00009bde131
😎 Deploy Preview https://deploy-preview-673--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kemuru
Copy link
Contributor

kemuru commented Apr 9, 2023

hey mate, I mentioned all the correct links a while ago, you can find them here:
#625

for your convenience i'll paste them again:

correct links, respectively:

https://forum.kleros.io/
https://snapshot.org/#/kleros.eth/
https://kleros.io/coop/
https://t.me/kleros
https://discord.com/invite/cAvWk8B23f
https://t.me/kleros
https://slack.kleros.io/

(Add them, push again, and I will merge it)

@Arun9650
Copy link
Contributor Author

Arun9650 commented Apr 9, 2023

and for the community calls, is this the link https://kleros.io/community ?

@kemuru
Copy link
Contributor

kemuru commented Apr 9, 2023

AFAIK the community calls are done in Telegram

kemuru
kemuru previously approved these changes Apr 9, 2023
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One detail, to be able to merge in kleros-v2 it is necessary that all the commits in the PR have been signed. To sign commits, you must register a GPG key in Github and to sign previous commits, you must do a rebase. Here are some links that might help you:

Adding a GPG key to your Github account: https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account
Generating a new GPG key: https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key
If you are on a branch other than master:
git rebase --exec 'git commit --amend --no-edit -n -S' -i master

If you are on master (where N is the number of commits you want to sign):
git rebase -i HEAD~N

Then, if the changes were already on the remote, to force push:
git push --force-with-lease.

@jaybuidl jaybuidl changed the title fix(web): links to socails fix(web): links to socials Apr 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Apr 10, 2023

Code Climate has analyzed commit d27a189 and detected 0 issues on this pull request.

View more on Code Climate.

@jaybuidl jaybuidl self-requested a review April 10, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded values: "www.google.com" in consts/community-elements
3 participants