Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add navbar settings and notifications pop-ups #824

Merged
merged 12 commits into from
Jun 7, 2023
Merged

feat: add navbar settings and notifications pop-ups #824

merged 12 commits into from
Jun 7, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented May 14, 2023 •
edited
Loading

add navbar Settings -> "General" and "Notifications" pop-ups

Few comments:

  1. the "Tabs" in the Kleros UI Components might have to be modified to have dynamic width. Its not responsive at low resolutions.
  2. the "Checkbox" in the Kleros UI Components seems to have a bug in dark mode too, where the "check" can be visible even if the box is not checked.
  3. The logic I did for making the pop-ups appear, its the one I came up with, but feel free to modify it if you find a better one.
2023-05-14.18-11-34.mp4

@netlify
Copy link

netlify bot commented May 14, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 1369e54
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6480494064592b00080a53cc
😎 Deploy Preview https://deploy-preview-824--kleros-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaybuidl jaybuidl linked an issue Jun 5, 2023 that may be closed by this pull request
Settings, Notification and Activity popup #272
Closed
alcercu
alcercu reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try also to prevent background scrolling when the navbar is open. File: src/layout/Header/navbar/index.tsx

@netlify
Copy link

netlify bot commented Jun 7, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 1369e54
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/648049407ed6a200082edd2c
😎 Deploy Preview https://deploy-preview-824--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

alcercu
alcercu previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alcercu
alcercu approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 0919bd1 into dev Jun 7, 2023
@alcercu alcercu deleted the feat(web)/add-navbar-settings branch June 7, 2023 09:24
@jaybuidl jaybuidl added this to the alpha-1 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Feature🗿
Projects
None yet
Milestone
testnet-1
Development

Successfully merging this pull request may close these issues.

Settings, Notification and Activity popup
3 participants
@kemuru @alcercu @jaybuidl