Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev merge into feat/multi-network-relayer #414

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Dev merge into feat/multi-network-relayer #414

merged 4 commits into from
Mar 24, 2025

Conversation

mani99brar
Copy link
Contributor

@mani99brar mani99brar commented Mar 24, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Documentation

    • Revised contract deployment details and network addresses to ensure accurate, up-to-date references.

  • Chores

    • Updated deployment configurations across networks with improved transaction and gas usage parameters.
    • Bumped package versions to signal a new release.

  • Refactor

    • Standardized event logging across verification processes, ensuring that verification events are emitted consistently for improved traceability.

@mani99brar mani99brar requested a review from jaybuidl as a code owner March 24, 2025 05:36
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates various contract deployment details and addresses across multiple networks. It revises JSON and YAML deployment files, updates the README and package versions, and modifies Solidity contracts to emit a verification event unconditionally. These changes affect contracts deployed on Sepolia, Arbitrum Sepolia, Chiado, and related devnets, ensuring that new addresses and deployment metadata are correctly recorded and that event logging in verification functions is consistent.

Changes

File(s) Change Summary
contracts/README.md Updated deployed contract addresses for multiple networks (Sepolia, Arbitrum Sepolia, Chiado).
contracts/deployments/arbitrumSepolia/VeaInboxArbToEthDevnet.json
contracts/deployments/arbitrumSepolia/VeaInboxArbToGnosisDevnet.json
contracts/deployments/arbitrumSepolia/VeaInboxArbToGnosisTestnet.json		 Updated deployment details: contract addresses, transaction hashes, gas usage, block numbers, args, and deployment counts for VeaInbox contracts.
contracts/deployments/sepolia/RouterArbToGnosisDevnet.json
contracts/deployments/sepolia/RouterArbToGnosisTestnet.json		 Updated router deployment files: revised contract addresses, transaction details, ABI event naming conventions, indices, and deployment metadata.
contracts/package.json Updated package version from "0.5.0" to "0.6.0".
relayer-subgraph-inbox/package.json Updated package version from "0.2.2" to "0.2.3".
relayer-subgraph-inbox/subgraph.yaml Updated data source configurations: modified contract addresses and start blocks for several VeaInbox contracts.
contracts/src/arbitrumToEth/VeaOutboxArbToEth.sol
contracts/src/arbitrumToGnosis/VeaOutboxArbToGnosis.sol
contracts/src/devnets/arbitrumToEth/VeaOutboxArbToEthDevnet.sol
contracts/src/devnets/arbitrumToGnosis/VeaOutboxArbToGnosisDevnet.sol
contracts/src/gnosisToArbitrum/VeaOutboxGnosisToArb.sol
(and similar)		 Modified verification functions to emit the Verified event unconditionally, ensuring event logging regardless of epoch comparisons.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Contract
    Note over Contract: Verification function call
    User->>Contract: invoke verifySnapshot / resolveDisputedClaim
    Contract->>Contract: Update state (e.g., claimHashes, latestVerifiedEpoch)
    Contract-->>Contract: Unconditionally emit Verified event
    Contract->>User: Return transaction receipt
Loading

Possibly related PRs

Suggested labels

Type: Maintenance :construction:, Type: Feature🗿, Package: Contracts

Suggested reviewers

  • jaybuidl
  • alcercu

Poem

I'm a little bunny on the run,
Hopping through code under the sun,
Adding events with a joyful cheer,
Verified each moment, loud and clear!
With new addresses shining bright,
I nibble bugs away—oh what a sight! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 786a113 and e292028.

📒 Files selected for processing (15)
  • contracts/README.md (1 hunks)
  • contracts/deployments/arbitrumSepolia/VeaInboxArbToEthDevnet.json (2 hunks)
  • contracts/deployments/arbitrumSepolia/VeaInboxArbToGnosisDevnet.json (2 hunks)
  • contracts/deployments/arbitrumSepolia/VeaInboxArbToGnosisTestnet.json (2 hunks)
  • contracts/deployments/sepolia/RouterArbToGnosisDevnet.json (8 hunks)
  • contracts/deployments/sepolia/RouterArbToGnosisTestnet.json (9 hunks)
  • contracts/package.json (1 hunks)
  • contracts/src/arbitrumToEth/VeaOutboxArbToEth.sol (2 hunks)
  • contracts/src/arbitrumToGnosis/VeaOutboxArbToGnosis.sol (2 hunks)
  • contracts/src/devnets/arbitrumToEth/VeaOutboxArbToEthDevnet.sol (1 hunks)
  • contracts/src/devnets/arbitrumToGnosis/VeaOutboxArbToGnosisDevnet.sol (1 hunks)
  • contracts/src/devnets/gnosisToArbitrum/VeaOutboxGnosisToArbDevnet.sol (1 hunks)
  • contracts/src/gnosisToArbitrum/VeaOutboxGnosisToArb.sol (2 hunks)
  • relayer-subgraph-inbox/package.json (1 hunks)
  • relayer-subgraph-inbox/subgraph.yaml (3 hunks)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mani99brar mani99brar merged commit 0cb7037 into feat/multi-network-relayer Mar 24, 2025
11 of 19 checks passed
@netlify Netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

❌ Deploy Preview for veascan failed. Why did it fail? →

Name Link
🔨 Latest commit e292028
🔍 Latest deploy log https://app.netlify.com/sites/veascan/deploys/67e0ef7b9738ee00083341bd

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaybuidl jaybuidl Awaiting requested review from jaybuidl jaybuidl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mani99brar @jaybuidl