-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make credential structure used for monitoring configurable #144
Comments
Do you think it would be feasible to make the password-key and username-key configurable in the helm chart values? Because changing the value from I imagine it could be set as |
db-operator/charts/db-instances/templates/postgres_exporter.yaml Lines 34 to 35 in 27daa92
This would also have to be configurable, because the zalando operator builds the service name differently from the $name (without prefix and suffix) and additionally zalandos default pg_hba only allows SSL connections from non-localhost. |
Would you accept a Pull Request which makes the user and password key and the DATA_SOURCE_URI more configurable or do you plan to change this yourself? // CC @sookloeckner , @hyunysmile |
…rwritten per db instance Solves kloeckner-i#144
I'm migrating to the integrated monitoring because of #138
I see the following issues:
Duplicate definition of admin secrets
Not a big deal, just a bit duplication of code when using
existingAdminSecret
. Monitoring templates will just look atadminUserSecret
. If the existing one is defined, it could use that one?Structure of secret hardcoded
For some reason, while
existingAdminSecret
works, the same secret doesn't for the pg_exporter.I'm using the zalando postgres operator and it creates secrets with
username
andpassword
as keys. The monitoring pod expectsuser
andpassword
:db-operator/charts/db-instances/templates/postgres_exporter.yaml
Lines 36 to 39 in 27daa92
If I'm not mistaken, the operator itself has a fallback to use the "postgres" user in that case, which apparently works in my setup:
https://github.com/kloeckner-i/db-operator/blame/aefb00fb1ac9e37db02706f7e2209c8c26e7a23e/pkg/utils/database/postgres.go#L356-L365
Changing the secret in the operator is not possible yet: zalando/postgres-operator#1746
The text was updated successfully, but these errors were encountered: