-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding local field to function for handling transient spec (Local.Remote) #2121
Conversation
d17cda5
to
824941c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
==========================================
+ Coverage 61.68% 65.14% +3.46%
==========================================
Files 106 108 +2
Lines 13693 13919 +226
==========================================
+ Hits 8446 9068 +622
+ Misses 4400 3952 -448
- Partials 847 899 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good. Thanks for the contribution @vyasgun !
// Local represents the transient runtime metadata which | ||
// is only relevant to the local copy of the function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good explanation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a
Local
field to represent the local spec (such asRemote
)Changes
Local.Remote
to thefunction
specfunc.write
to write it only to.func/local.yaml
so it is not persisted across clones but only locally/kind enhancement
Fixes #
Release Note
Docs