Skip to content

Handle non existing collection #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yangwao opened this issue Dec 7, 2021 · 1 comment · Fixed by #1572
Closed

Handle non existing collection #1413

yangwao opened this issue Dec 7, 2021 · 1 comment · Fixed by #1572
Labels
$ ~<50usd bug Something isn't working enhancement New feature or request p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Dec 7, 2021

When I open
https://kodadot.xyz/rmrk/collection/10352274-409E451AFD98397563-AURA3D-AURA-V-0000000000000006

Keeps loading, but users really don't know if it's an issue in internet, our bug or what's happening.

We should handle somehow that user is opening non-existing collection, item, etc.

image
@yangwao yangwao added bug Something isn't working enhancement New feature or request $ ~<50usd p2 core functionality, or is affecting 60% of app labels Dec 7, 2021
@prachi00
Copy link
Member

prachi00 commented Dec 7, 2021

maybe we can handle this by routing the user to /collection if the collection doesn't exist? @yangwao

prachi00 added a commit to prachi00/nft-gallery that referenced this issue Dec 19, 2021
@prachi00
kodadot#1413 Handle non existing collection
96e5313
@prachi00 prachi00 mentioned this issue Dec 19, 2021
Closed
16 tasks
prachi00 added a commit to prachi00/nft-gallery that referenced this issue Dec 20, 2021
@prachi00
kodadot#1413 Handle non existing collection
12eaa8e
prachi00 added a commit to prachi00/nft-gallery that referenced this issue Dec 20, 2021
@prachi00
kodadot#1413 Handle non existing collection
5db39a1
@prachi00 prachi00 mentioned this issue Dec 20, 2021
Merged
16 tasks
yangwao added a commit that referenced this issue Dec 21, 2021
@yangwao
Merge pull request #1572 from prachi00/feat-nuxt-collections-error
b58acc8 
#1413 Handle non existing collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd bug Something isn't working enhancement New feature or request p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1413 Handle non existing collection prachi00/nft-gallery
2 participants
@yangwao @prachi00