Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove super().assert_extra_args() call in sdxl_train #1961

Closed
wants to merge 1 commit into from

Conversation

MakkiShizu
Copy link

Description

Fixes AssertionError when training SDXL LoRA models with bucket_reso_steps=32.

Problem:

  • Parent class train_network.py #L98 enforced
    def assert_extra_args(self, args, train_dataset_group):
        train_dataset_group.verify_bucket_reso_steps(64)
  • SDXL subclass attempted to set 32 after parent validation, causing conflict

Changes:

  1. In sdxl_train_textual_inversion.py,sdxl_train_network.py Removed super().assert_extra_args() in SdxlNetworkTrainer.assert_extra_args

Verification:

  • Confirmed no more bucket_reso_steps=32 assertion failures in SDXL mode

@kohya-ss
Copy link
Owner

Thank you for this, and I apologize that I did not notice this PR. I merged the same update in #1966, so I will close this one.

@kohya-ss kohya-ss closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants