feat(markdown): code with links styles (#DS-3218) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a4c18f0): https://koobiq-next--prs-473-dehz5jmk.web.app (expires Sun, 15 Dec 2024 14:06:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
@sk8knut посмотрел наработки, что заметил / хотел бы уточнить:
|
NikGurev
reviewed
Dec 10, 2024
apps/docs/scripts/build-tokens.js
Outdated
| @@ -8,6 +8,7 @@ require('@koobiq/tokens-builder/transforms/attribute/palette.js')(StyleDictionar | |||
| require('@koobiq/tokens-builder/transforms/attribute/prefix.js')(StyleDictionary); | |||
| require('@koobiq/tokens-builder/transforms/attribute/font.js')(StyleDictionary); | |||
| require('@koobiq/tokens-builder/transforms/attribute/theme.js')(StyleDictionary); | |||
| require('@koobiq/tokens-builder/transforms/attribute/scss-value.js')(StyleDictionary); | |||
There was a problem hiding this comment.
Подтяни main, там этот фикс есть
|
Инлайн код отображается без скруглений, так и должно быть?
|
|
@sk8knut вижу radiuses по 8px, супер) |
vitalyozza
approved these changes
Dec 11, 2024
NikGurev
approved these changes
Dec 11, 2024
sk8knut
added a commit
that referenced
this pull request
Dec 16, 2024
* main: chore: remove vsix chore(docs): removed redundant code (#481) feat(timezone): select search fix (#DS-3213) (#479) chore: bump version to 18.10.0 w/ changelog feat(docs): design-tokens page (#DS-2997) (#468) feat(markdown): code with links styles (#DS-3218) (#473) fix(cdk): resolve event target within shadow-root (#DS-2632) (#475) feat(form-field): autofill backgrounds (#DS-2873) (#476) fix(docs): added build-tokens script missing transform (#474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.