Fix for negative number handling (DECIMAL -51.1234 could not read). #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his seems to fix it. Inspired by fengxiangyun/mysql-replication@a9da836
Playing around to get composer use this fork with the negative number fix...
krowinski
reviewed
Mar 3, 2021
Add test for negative decimal value reading
|
Should be all good this time. I added a the test and fixed the code. |
|
I was not able to test the BinaryDataReader::readInt40Be function (I only managed to go up to 32 bits ints), so I can't tell if it is missing a "fix" like the 32bit or lower version, or if it is ok. |
|
GJ! tx for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for considering my bug report. I have investigated a little deeper and found a solution that seems to work correctly (and read numbers correctly).
The PHPUnit test passes (although not totally, I am running a MariaDB not a MySQL server so the mysql-specific tests are skipped), however I could not seem to find anything that tests that "INTs" are decoded correctly. I'm not really a pro of PHPUnit so I may well have missed something.
Anyway, I'm trying to help on this cool project so here is a stone to the building. Glad if it can help !
Inspired by fengxiangyun/mysql-replication@a9da836