Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken page-meta links #3625

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 16, 2023


Before

After

/cc @sarahmaddox @LisaFC

Copy link

@chalin: GitHub didn't allow me to request PR reviews from the following users: LisaFC.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:


Before

After

/cc @sarahmaddox @LisaFC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Hi @chalin. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chalin
Copy link
Contributor Author

chalin commented Nov 16, 2023

/cc @nate-double-u

Copy link

@chalin: GitHub didn't allow me to request PR reviews from the following users: nate-double-u.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nate-double-u

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@thesuperzapper
Copy link
Member

@chalin thanks for this, I can confirm this fixes the edit page issue
/lgtm

@thesuperzapper
Copy link
Member

@zijianjoy this is a very small but important fix on the website, as it fixes the "edit page" button to help people make changes to the website.

We need a root approver.

@zijianjoy
Copy link
Contributor

/approve

Thank you for the change!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chalin, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5df356f into kubeflow:master Nov 25, 2023
@chalin chalin deleted the chalin-gp-fix-page-meta-2023-11-6 branch November 27, 2023 19:57
@chalin
Copy link
Contributor Author

chalin commented Nov 29, 2023

@zijianjoy, @thesuperzapper, et al.: as a follow up, I wanted to mention that if the the default branch is renamed per the LF/CNCF inclusive naming initiative, as stated in:

Then, of course, the github_branch override will need to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken logic for building GitHub URL for "Edit this page" link
4 participants