-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken page-meta links #3625
Fix broken page-meta links #3625
Conversation
@chalin: GitHub didn't allow me to request PR reviews from the following users: LisaFC. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @chalin. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @nate-double-u |
@chalin: GitHub didn't allow me to request PR reviews from the following users: nate-double-u. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@chalin thanks for this, I can confirm this fixes the edit page issue |
@zijianjoy this is a very small but important fix on the website, as it fixes the "edit page" button to help people make changes to the website. We need a root approver. |
/approve Thank you for the change! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chalin, zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zijianjoy, @thesuperzapper, et al.: as a follow up, I wanted to mention that if the the default branch is renamed per the LF/CNCF inclusive naming initiative, as stated in: Then, of course, the |
Before
main
After
/cc @sarahmaddox @LisaFC