🐛 Fakeclient: preserve TypeMeta for PartialObjectMeta resources

[bigkevmcd]

This updates the fake client to retain the PartialObjectMeta TypeMeta when getting resources.

Fixes: #2923

[k8s-ci-robot]

Welcome @bigkevmcd!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bigkevmcd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alvaroaleman]

/retitlte 🐛 Fakeclient: preserve TypeMeta for PartialObjectMeta resource
/lgtm
/approve

Thanks!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: f1337f923acb7c5e990b4497c1848ee0e589ffdb

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2dfc12d5c018ebbdac53070db2aa0c5148ae1e64

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, bigkevmcd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bigkevmcd]

/test pull-controller-runtime-test

[k8s-ci-robot]

@bigkevmcd: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-controller-runtime-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[troy0820]

/ok-to-test
/test pull-controller-runtime-test

[troy0820]

@alvaroaleman @sbueringer did you all want this backported? 👀

/cherry-pick release-0.19

[troy0820]

/cherry-pick release-0.18

[k8s-infra-cherrypick-robot]

@troy0820: new pull request created: #2951

In response to this:

@alvaroaleman @sbueringer did you all want this backported? 👀

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@troy0820: new pull request created: #2952

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

Yeah let's backport. I think it's very unlikely that folks rely on PartialObjectMeta missing TypeMeta (or it should happen very very rarely).

So the backport shouldn't have any negative effects