🐛 Fix a bug in the priorityqueue metrics #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
commented
Jan 10, 2025
| @@ -34,7 +33,6 @@ func newQueueMetrics[T comparable](mp workqueue.MetricsProvider, name string, cl | |||
| workDuration: mp.NewWorkDurationMetric(name), | |||
| unfinishedWorkSeconds: mp.NewUnfinishedWorkSecondsMetric(name), | |||
| longestRunningProcessor: mp.NewLongestRunningProcessorSecondsMetric(name), | |||
| added: sets.Set[T]{}, | |||
There was a problem hiding this comment.
This secondary bookkeeping was added because originally the queue called metrics.Add when the queues Add was called before I realized this is wrong, now that metrics.add is only called when an item was newly-added or became ready, this isn't needed anymore
The priorityqueue needs to call `metrics.add` but only once an item was ready. When an item was initially added with `After`, so not ready, then without which makes it ready, we didn't do that, resulting in potentially negative values for the queue depth metric.
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3ca83db8c337ed490b65c0ecbb213af7afacb840
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The priorityqueue needs to call
metrics.addbut only once an item was ready. When an item was initially added withAfter, so not ready, then without which makes it ready, we didn't do that, resulting in potentially negative values for the queue depth metric.