Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.20] 🐛 Revert "✨ Expose all Go runtime metrics" #3147

Merged
merged 1 commit into from
Mar 8, 2025
Merged

[release-0.20] 🐛 Revert "✨ Expose all Go runtime metrics" #3147

merged 1 commit into from
Mar 8, 2025

Conversation

alvaroaleman
Copy link
Member

This reverts commit fc48583.

This change breaks some users.

Fixes #3144

@alvaroaleman alvaroaleman requested a review from sbueringer March 7, 2025 20:20
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from joelanford March 7, 2025 20:20
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2025
@alvaroaleman alvaroaleman changed the title Revert "[release-0.20] ✨ Expose all Go runtime metrics (#3100)" 🐛 Revert "[release-0.20] ✨ Expose all Go runtime metrics (#3100)" Mar 7, 2025
@sbueringer sbueringer changed the title 🐛 Revert "[release-0.20] ✨ Expose all Go runtime metrics (#3100)" [release-0.20] 🐛 Revert "✨ Expose all Go runtime metrics (#3100)" Mar 8, 2025
@sbueringer sbueringer changed the title [release-0.20] 🐛 Revert "✨ Expose all Go runtime metrics (#3100)" [release-0.20] 🐛 Revert "✨ Expose all Go runtime metrics" Mar 8, 2025
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcb7e1aa73a4350ae1ae90afc8ded74256881457

@sbueringer
Copy link
Member

/cherry-pick release-0.19

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit bd9c786 into kubernetes-sigs:release-0.20 Mar 8, 2025
12 of 15 checks passed
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #3148

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer Awaiting requested review from sbueringer

@joelanford joelanford Awaiting requested review from joelanford

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvaroaleman @k8s-ci-robot @sbueringer @k8s-infra-cherrypick-robot